I think so. We did not submit a modules for recertification with these changes, but we do not plan this in close future so you can consider it completed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Tue, May 7
Fri, Apr 26
Mar 28 2024
For the reference, for now i just did the dummy install in the Fedora spec file:
Feb 12 2024
Jan 31 2024
Nov 27 2023
Nope, The gpgconf --kill keyboxd hangs too, if I see right, while waiting for agent:
$ strace gpgconf --kill keyboxd [...] clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7f2d74fe2a10) = 3244 wait4(3244, 0x7ffc9836e364, 0, NULL) = ? ERESTARTSYS (To be restarted if SA_RESTART is set)
Nov 24 2023
Aug 29 2023
Jun 27 2023
From the FIPS 186-5 there are some limitations to use the SHAKE in FIPS Mode that we will have to reflect:
Jun 20 2023
Thank you for having a look into that! The proposed patch looks good. Should we have this change also in master?
Jun 15 2023
Jun 13 2023
Another approach would be having "non-hash" algo for gcry_md_open.
Jun 12 2023
FYI, while going through the licenses again I noticed one of the pinentry files have even older address that so if you would do sed, this would not be matched:
Jun 1 2023
Correct, but the last revision of FIPS 140-3 lists the EdDSA already. The same for the IG for FIPS 140-3:
May 31 2023
May 30 2023
Mar 30 2023
Mar 20 2023
Mar 6 2023
Actually, the same issue is in the mac case, which I missed on first couple of reviews:
- enum gcry_mac_algos alg = va_arg (arg_ptr, enum gcry_cipher_algos); + enum gcry_mac_algos alg = va_arg (arg_ptr, enum gcry_mac_algos);
We discussed this further with the lab and there are more problematic flags that we need to "cut" and we can not do that always in the code as for example the RFC6979 (deterministic ECDSA signatures) are not allowed in the current version of the FIPS documents, but it is used in the selftests (which is weirdly enough allowed) so we just need to mark it unapproved. Lets discuss this further tomorrow.
Going through the code once more, there is one typo to be fixed:
+_gcry_fips_indicator_md (va_list arg_ptr) +{ + enum gcry_md_algos alg = va_arg (arg_ptr, enum gcry_cipher_algos);
should say
+_gcry_fips_indicator_md (va_list arg_ptr) +{ + enum gcry_md_algos alg = va_arg (arg_ptr, enum gcry_md_algos);
otherwise ack.
Mar 2 2023
Mar 1 2023
We came to the same conclusion -- the SHAKE digests are not usable for sign/verify operations the way how it is implemented now. But it would be more clear if we would have explicit allow-list.
Nov 30 2022
Nov 10 2022
Oct 20 2022
In regards to this issue, we were also notified that the MD API using gcry_md_setkey() can be used to calculate HMACs and it does not have the needed input key length limitation. From the discussion here I read that we would like to keep the internal usage still available so my proposal would be to to add similar check as in gcry_mac_setkey() into the above function. Together with the revert, it is available in the following merge request:
In T6039#164435, @gniibe wrote:I read the document (SP 800-131Ar2) again. I think that it would be irrelevant for PKDF2, because it's password KDF, not deriving additional keys from a Cryptographic Key.
Oct 18 2022
Oct 7 2022
One more nit regarding to the test is the format string for size_t which was using %d instead of %zu. This is fixed by the attached patch:
Oct 5 2022
I tried to clarify the comment in the following merge request. Feel free to pull it from there or adjust if it is too verbose or missing some points:
Oct 4 2022
Why is that not stated in my man page which knows about kernel 3.19? Is that a regression or a RedHat specific patch?
Sep 30 2022
One nit that I overlooked initially is the memory leak, which is fixed with the following patch:
Sep 27 2022
The specs https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-132.pdf page 10 says specifically:
Sep 26 2022
The test looks good. I hope I changed the API in all the hw optimized implementations.
Sep 23 2022
This still did not seem to help me in making the tests working on Fedora with git master. I am still getting wrong paths to the gpgconf
gpgscm: error running '/root/gnupg/tests/tools/gpgconf': probably not installed
There is a full reproducer and more complete log in https://bugzilla.redhat.com/show_bug.cgi?id=2089075#c11
Sep 19 2022
Aug 23 2022
Thank you for your work on the proposal. I have two comments:
- Do we have some test vector, which can be used in the testsute to test the new API?
- We need to mention the new API in the documentation.
Aug 18 2022
For the record, the changeset in the attached merge request is final and waiting for reviews.
Aug 9 2022
Aug 1 2022
The provided change does not look like fixing the problem for me. The path to gpgconf is still wrong and I am getting the same error both with master and with the patched tarballs:
make[2]: Entering directory '/home/jjelen/devel/gnupg/tests/tpm2dtests' LC_ALL=C EXEEXT= PATH="../gpgscm:/home/jjelen/.local/bin:/home/jjelen/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin" abs_top_srcdir="/home/jjelen/devel/gnupg" objdir="/home/jjelen/devel/gnupg" TPMSERVER="" SWTPM="/bin/swtpm" SWTPM_IOCTL="/bin/swtpm_ioctl" GNUPG_BUILD_ROOT="/home/jjelen/devel/gnupg/tests" GPGSCM_PATH="/home/jjelen/devel/gnupg/tests/gpgscm" /home/jjelen/devel/gnupg/tests/gpgscm/gpgscm \ /home/jjelen/devel/gnupg/tests/tpm2dtests/run-tests.scm gpgscm: error running '/home/jjelen/devel/gnupg/tests/tools/gpgconf': probably not installed (wait-process "/home/jjelen/devel/gnupg/tests/tools/gpgconf" 2693795 #t): Configuration error