Page MenuHome GnuPG
Feed All Stories

May 14 2019

aheinecke added a comment to T4505: SM, W32: GPGSM hangs up the GnuPG System.

To reproduce this issue I started Kleopatra with an empty GNUPGHOME and imported 10 S/MIME certs at once (which spawns a gpgsm process each) with enabled logging.

May 14 2019, 11:20 AM · Restricted Project, gpgol, S/MIME, gpg4win, Windows
werner triaged T4503: include extension for OpenPGP creation timestamp in X.509 output as Normal priority.

Thanks for the hint on the existing OID I already looked into that and planned to use one from the GnuPG arc, But an existing OID is better. I still need to figure useful workflows but something like this will be useful for smartcards..

May 14 2019, 10:42 AM · Feature Request, S/MIME
werner closed T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures as Resolved.
May 14 2019, 10:35 AM · gnupg (gpg22), Bug Report
werner committed rG110932925ba8: agent: correct length for uri and comment on 64-bit big-endian platforms (authored by dkg).
agent: correct length for uri and comment on 64-bit big-endian platforms
May 14 2019, 10:34 AM
werner committed rG5651b2c460a7: agent: correct length for uri and comment on 64-bit big-endian platforms (authored by dkg).
agent: correct length for uri and comment on 64-bit big-endian platforms
May 14 2019, 10:34 AM
werner committed rG54e96c6fd262: agent: Replace most assert by log_assert. (authored by werner).
agent: Replace most assert by log_assert.
May 14 2019, 10:34 AM
werner added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

Good catch. Thanks for that work. I'll apply it to master and 2.2.

May 14 2019, 10:33 AM · gnupg (gpg22), Bug Report
werner triaged T4513: dirmngr should try the configured keyservers anyway even if they are all dead as Normal priority.
May 14 2019, 10:09 AM · Feature Request, Keyserver, dirmngr
werner closed T4507: show-only-fpr-mbox shows user-ids that are not valid as Resolved.
May 14 2019, 10:08 AM · Bug Report
werner committed rG49a679eb3596: doc: Minor edit for a gpg option. (authored by werner).
doc: Minor edit for a gpg option.
May 14 2019, 10:07 AM
werner committed rG3c2198e907c6: doc: Minor edit for a gpg option. (authored by werner).
doc: Minor edit for a gpg option.
May 14 2019, 10:07 AM
werner added a comment to T4507: show-only-fpr-mbox shows user-ids that are not valid.

Yes, that term is overloaded. The reason in this case is that we once replaced "trusted key" by "valid key". That term "valid" now conflicts with another older use of valid. Using "self-signed" here seems to be more confusing that just removing the (first) "valid".

May 14 2019, 10:04 AM · Bug Report
werner added a comment to T4511: dirmngr error logs claim that HTTP GET requests are percent-escaped, but they are not.

This is easy to explain: dirmngr receives already escaped data and that is what you see in the log. For proper parsing of the URI the escaping needs to be removed and only before sending the request the required escaping is applied. '@', '<', and '>' do not need to be escaped and thus you see them as they are.

May 14 2019, 9:59 AM · Bug Report, dirmngr
werner claimed T4511: dirmngr error logs claim that HTTP GET requests are percent-escaped, but they are not.
May 14 2019, 8:52 AM · Bug Report, dirmngr
werner triaged T4514: Batch mode/unattended key generation: support multiple subkeys as Normal priority.

I anyway plan to extend the --quick-gen-key parameters to allow the specification of several subkeys on the command line.

May 14 2019, 8:44 AM · gnupg24, gnupg (gpg23), Feature Request
werner closed T4512: gpg's --keyserver option should be more robustly deprecated as Resolved.

I removed this specialized error message. Thanks for reporting.

May 14 2019, 8:38 AM · gnupg24, gnupg (gpg23), Documentation, Keyserver, Bug Report
werner committed rG8d645f1d1f2b: gpg: Do not print a hint to use the deprecated --keyserver option. (authored by werner).
gpg: Do not print a hint to use the deprecated --keyserver option.
May 14 2019, 8:38 AM
gniibe added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

While original npth-1.6 can be compiled with newer gcc (>= 5), we'd say please use CFLAGS+=-std=gnu99 with older gcc, as workaround.

May 14 2019, 8:08 AM · npth, Bug Report
gniibe added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

I figured out:

  • Removing -D_POSIX_C_SOURCE=200112L works both of gcc 4.9 and gcc 5.5 on Solaris 11.3 (even with -std=c99).
  • Then, adding -D_XOPEN_SOURCE=500, gcc 4.9 works, but gcc 5.5 failed by another error (Compiler or options invalid for pre-UNIX 03 X/Open applications and pre-2001 POSIX applications)
    • I confirmed gcc 5.5 defaults to -std=gnu99
May 14 2019, 8:05 AM · npth, Bug Report
werner committed rG7102d9b798b0: gpg: Do not print a hint to use the deprecated --keyserver option. (authored by werner).
gpg: Do not print a hint to use the deprecated --keyserver option.
May 14 2019, 7:56 AM
dkg added a comment to T4514: Batch mode/unattended key generation: support multiple subkeys.

I think you'll be better off doing this with the simpler --quick-generate-key and --quick-add-key interfaces, rather than hacking on the domain-specific language used by --batch --generate-key.

May 14 2019, 7:55 AM · gnupg24, gnupg (gpg23), Feature Request
dkg updated the task description for T4512: gpg's --keyserver option should be more robustly deprecated.
May 14 2019, 7:42 AM · gnupg24, gnupg (gpg23), Documentation, Keyserver, Bug Report
dkg edited projects for T4466: Clean up --keyserver documentation in gpg(1), added: dirmngr, gnupg (gpg22), Keyserver; removed gnupg.
May 14 2019, 7:40 AM · Keyserver, gnupg (gpg22), dirmngr, Documentation
gniibe added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

Thanks for your offer. I have an account for GCC Compiler Farm. I'm trying with gcc211 machine. will back soon.

May 14 2019, 7:39 AM · npth, Bug Report
JW added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

In case of gcc 4.8 on Solaris, could you please try this patch (instead of configure patch) to see if it works?

May 14 2019, 7:35 AM · npth, Bug Report
gniibe added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

It looks like somewhat complicated more. It seems that specifying _POSIX_C_SOURCE=200112L is not good on Solaris with old GCC. Perhaps, it would have no problem with newer gcc (or -std=gnu99 option).

May 14 2019, 7:30 AM · npth, Bug Report
dkg added a comment to T4490: --export-secret-keys fails with unusually-created secret key.

I think this patch should be backported to STABLE-BRANCH-2-2

May 14 2019, 6:35 AM · ssh, gnupg (gpg22)
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

I think this patch should be backported to STABLE-BRANCH-2-2

May 14 2019, 6:35 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

I can confirm that this fix repairs the problem on debian's s390x.

May 14 2019, 6:15 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

I've just pushed e4a158faacd67e15e87183fb48e8bd0cc70f90a8 to branch dkg/fix-T4501 as a proposed fix for this specific problem (it doesn't introduce anything in the test suite, or try to deal with any of the other %b problems).

May 14 2019, 6:15 AM · gnupg (gpg22), Bug Report
dkg committed rGe4a158faacd6: agent: correct length for uri and comment on 64-bit big-endian platforms (authored by dkg).
agent: correct length for uri and comment on 64-bit big-endian platforms
May 14 2019, 6:14 AM
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

OK, i think the reason this is happening is that agent_public_key_from_file (in agent/findkey.c) is screwing up a %b format string in gcry_sexp_build_array.

May 14 2019, 5:57 AM · gnupg (gpg22), Bug Report
ageis updated the task description for T4514: Batch mode/unattended key generation: support multiple subkeys.
May 14 2019, 5:32 AM · gnupg24, gnupg (gpg23), Feature Request
ageis updated the task description for T4514: Batch mode/unattended key generation: support multiple subkeys.
May 14 2019, 5:19 AM · gnupg24, gnupg (gpg23), Feature Request
ageis created T4514: Batch mode/unattended key generation: support multiple subkeys.
May 14 2019, 5:18 AM · gnupg24, gnupg (gpg23), Feature Request
gniibe claimed T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

IIUC, -std=c99 won't solve this issue. It is Solaris specific C99 issue.

May 14 2019, 5:13 AM · npth, Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

Ok, the difference appears to be that on these 64-bit big-endian platforms, they're returning a zero-byte string for the associated comment. When this happens, gcry_sexp_canon_len returns 0 because of GPG_ERR_SEXP_ZERO_PREFIX. The same thing happens on x86_64 platforms when confronted with such an s-expression.

May 14 2019, 5:07 AM · gnupg (gpg22), Bug Report
JW added a comment to T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer...".

rG5b22d2c4008 tested good under Asan.

May 14 2019, 4:53 AM · gnupg
gniibe committed rEbdb9561a366f: tests: Fix a memory leak. (authored by gniibe).
tests: Fix a memory leak.
May 14 2019, 4:46 AM
gniibe claimed T4498: Asan findings in tests/t-logging.c.

Thanks for your report.
Let me handle issue by issue.

May 14 2019, 4:42 AM · gpgrt
gniibe changed the status of T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer..." from Open to Testing.

Thanks for your report.

May 14 2019, 4:27 AM · gnupg
gniibe committed rG802a2aa300ba: g10: Fix possible null dereference. (authored by gniibe).
g10: Fix possible null dereference.
May 14 2019, 4:26 AM
gniibe committed rG5b22d2c40089: g10: Fix possible null dereference. (authored by gniibe).
g10: Fix possible null dereference.
May 14 2019, 4:25 AM
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

It looks to me like gcry_sexp_canon_len is returning 0 on these platforms from within a backtrace like this:

May 14 2019, 4:21 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4490: --export-secret-keys fails with unusually-created secret key.

I've just pushed 29adca88f5f6425f5311c27bb839718a4956ec3a to the dkg/fix-T4490 branch, which i believe fixes this issue.

May 14 2019, 3:43 AM · ssh, gnupg (gpg22)
dkg committed rG29adca88f5f6: gpg: enable OpenPGP export of cleartext keys with comments (authored by dkg).
gpg: enable OpenPGP export of cleartext keys with comments
May 14 2019, 3:43 AM
wltjr claimed T4147: pinentry-efl does not grab input when requesting pin for authentication.

This is known and by design, basically it is a legacy X feature. For Wayland, the window manager determines if a window should be blocking, no grab or grab, not anything applications themselves have control over. This came up many times when I was first making the interfaces. You can reference these two comments, but there are many more in between them.

May 14 2019, 3:20 AM · Bug Report, pinentry
dkg added a comment to T4507: show-only-fpr-mbox shows user-ids that are not valid.

Validity values are also displayed for all user IDs.
[…]

show-uid-validity
       Display  the  calculated  validity of user IDs during key
       listings.  Defaults to yes.

[…]

Trust values are used to indicate ownertrust and validity of  keys  and
user IDs.  They are displayed with letters or strings:

[…]

revoked
       For validity only: the key or the user ID has been revoked.
May 14 2019, 2:30 AM · Bug Report
dkg committed rGf4dfeb9c80e1: doc: clarify intent for show-only-fpr-mbox (authored by dkg).
doc: clarify intent for show-only-fpr-mbox
May 14 2019, 2:29 AM
dkg added a comment to T4448: Add "Autocrypt" key-origin.

@werner, why is it the case that if i'm willing to look up a key via WKD on Monday, i should by definition also be willing to send a followup request to that WKD server on Thursday just because the certificate is marked with an expiration?

May 14 2019, 2:17 AM · Feature Request
gniibe committed rGcf73c82e95f9: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 14 2019, 1:58 AM
dkg added a comment to T4490: --export-secret-keys fails with unusually-created secret key.

And, i just discovered that when i manually edit the key to remove the (comment) list from the *.key S-expression file, the final --export-secret-key works fine. so the failure appears to be due to the presence of the (comment) clause. (same as in T4501)

May 14 2019, 1:48 AM · ssh, gnupg (gpg22)
JW added a comment to T4499: Asan finding in libgcrypt.

I was talking to Thomas Dickey, who maintains Ncurses. Ncurses had a leak and he offered a config option to remove it. Ncurses config responds to --disable-leaks.

May 14 2019, 1:45 AM · libgcrypt
gniibe added a comment to T4506: OpenPGP Key Certification Forgeries.

In my opinion, it's good if we can offer:

May 14 2019, 1:44 AM · gnupg (gpg22)
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

And, i just discovered that when i manually edit the key to remove the (comment) list from the *.key S-expression file, everything works fine on s390x. so the failure appears to be due to the (comment), just like in T4490.

May 14 2019, 1:37 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

fwiw, i've just tried loading the same keyfile that the s390x (64-bit big-endian) implementation choked on into a running gpg-agent on an amd64 machine (64-bit little-endian) and gpg --full-generate-key succeeded with that same key on amd64.

May 14 2019, 1:35 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4513: dirmngr should try the configured keyservers anyway even if they are all dead.

This is particularly bad for users who have manually specified a given keyserver in dirmngr.conf, because even a transient failure in that keyserver will prevent them from any future keyserver requests until dirmngr decides that the "death" has worn off.

May 14 2019, 1:00 AM · Feature Request, Keyserver, dirmngr
dkg created T4513: dirmngr should try the configured keyservers anyway even if they are all dead.
May 14 2019, 12:54 AM · Feature Request, Keyserver, dirmngr
dkg created T4512: gpg's --keyserver option should be more robustly deprecated.
May 14 2019, 12:49 AM · gnupg24, gnupg (gpg23), Documentation, Keyserver, Bug Report
dkg created T4511: dirmngr error logs claim that HTTP GET requests are percent-escaped, but they are not.
May 14 2019, 12:19 AM · Bug Report, dirmngr

May 13 2019

dkg added a comment to T4467: dirmngr keyserver option (and legacy gpg --keyserver) should assume `hkps://` or `hkp://` if no scheme is present.

further testing suggests that the invalid URI issue is only present for dirmngr's --keyserver option, and gpg's deprecated --keyserver option actually accepts schema-less hostnames.

May 13 2019, 11:33 PM · dirmngr
dkg updated the task description for T4467: dirmngr keyserver option (and legacy gpg --keyserver) should assume `hkps://` or `hkp://` if no scheme is present.
May 13 2019, 11:32 PM · dirmngr
dkg added a comment to T4493: Default to HKPS, not HKP.

see also T4467

May 13 2019, 11:12 PM · dirmngr, Feature Request
JW added a comment to T4499: Asan finding in libgcrypt.

Dynamic loading of Libgcrypt is anyway not supported; those who do that are on their own.

May 13 2019, 10:17 PM · libgcrypt
werner added a comment to T4507: show-only-fpr-mbox shows user-ids that are not valid.

"valid user-id" means a user id which is properly bound to the key; that is the self-signature checks out.

May 13 2019, 10:01 PM · Bug Report
werner created T4510: Update our copy of SQLite to 3.28.
May 13 2019, 7:40 PM · CVE
werner committed rGc1dc7a832921: gpg: Change update_keysig_packet to replace SHA-1 by SHA-256. (authored by werner).
gpg: Change update_keysig_packet to replace SHA-1 by SHA-256.
May 13 2019, 7:30 PM
werner added a parent task for T4508: gnupg1: digest-preference not honoured: T4509: Release GnuPG 2.2.16.
May 13 2019, 7:27 PM · gnupg (gpg22), Bug Report
werner added a subtask for T4509: Release GnuPG 2.2.16: T4508: gnupg1: digest-preference not honoured.
May 13 2019, 7:27 PM · Release Info, gnupg (gpg22)
werner created T4509: Release GnuPG 2.2.16.
May 13 2019, 7:26 PM · Release Info, gnupg (gpg22)
werner committed rG484d6ba5896a: gpg: Change update_keysig_packet to replace SHA-1 by SHA-256. (authored by werner).
gpg: Change update_keysig_packet to replace SHA-1 by SHA-256.
May 13 2019, 7:20 PM
werner triaged T4508: gnupg1: digest-preference not honoured as High priority.

I keep this open to track the mentioned change for gnupg 2.2

May 13 2019, 6:53 PM · gnupg (gpg22), Bug Report
werner added a comment to T4508: gnupg1: digest-preference not honoured.

How a digest algorithim is selected for a key signature

May 13 2019, 6:52 PM · gnupg (gpg22), Bug Report
werner added a comment to T4508: gnupg1: digest-preference not honoured.

No, personal-digest-preferences are not used to select a digest algorithm for key signatures. The only way to use a different digest-algorithm than select by gpg is by using --cert-digest-algo. But take care, you can easily cut into your fingers when using such override options.

May 13 2019, 6:49 PM · gnupg (gpg22), Bug Report
sdaoden created T4508: gnupg1: digest-preference not honoured.
May 13 2019, 6:30 PM · gnupg (gpg22), Bug Report
aa7356 added a comment to T4475: Gemalto IDBridge CT710 && Pinentry.

WK you command me to put the file scd.log somewhere.
I am trying to do it on the wires set "F103RB" from ARM (GeeNuke)

May 13 2019, 4:05 PM · Feature Request
werner triaged T4499: Asan finding in libgcrypt as Low priority.

I have not yet looked at the details but I do not consider one-time allocation a problem. If you want to silence ASAN it is possible to use gpgrt_annotate_leaked_object( foo). Dynamic loading of Libgcrypt is anyway not supported; those who do that are on their own.

May 13 2019, 4:01 PM · libgcrypt
dkg created T4507: show-only-fpr-mbox shows user-ids that are not valid.
May 13 2019, 3:47 PM · Bug Report
werner added a comment to T4506: OpenPGP Key Certification Forgeries.
  • For 2.3 we should ignore all SHA-1 key certifications and warn about SHA-1 binding signatures and offer to migrate them.
May 13 2019, 2:43 PM · gnupg (gpg22)
werner added a comment to T4506: OpenPGP Key Certification Forgeries.

How a digest algorithim is selected for a key signature

May 13 2019, 1:38 PM · gnupg (gpg22)
werner committed rGd07666412d43: gpg: Cleanup use of make_keysig_packet. (authored by werner).
gpg: Cleanup use of make_keysig_packet.
May 13 2019, 1:24 PM
werner changed the visibility for T4506: OpenPGP Key Certification Forgeries.
May 13 2019, 11:05 AM · gnupg (gpg22)
gniibe committed rP42c32e08d5a4: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 10:51 AM
gniibe committed rGPA1cb82dcfcea4: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 10:13 AM
aheinecke created T4505: SM, W32: GPGSM hangs up the GnuPG System.
May 13 2019, 9:39 AM · Restricted Project, gpgol, S/MIME, gpg4win, Windows
gniibe committed rE07b1b3be1798: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 9:32 AM
werner added a comment to T4504: Asan findings in iconv configure test causing config failure.

We update condig.{guess,sub} only when needed. In the past we had cases with regressions on some rare platforms.

May 13 2019, 8:49 AM · gpgrt, gnupg
gniibe claimed T4397: GPG Error - version >= 1.25... no.

It is because you don't have ${prefix}/bin in your PATH.
Please build having /var/tmp/bin in your PATH.

May 13 2019, 8:35 AM · gpgrt, Bug Report
gniibe added a project to T4504: Asan findings in iconv configure test causing config failure: gpgrt.
May 13 2019, 8:17 AM · gpgrt, gnupg
gniibe committed rG1cd2aca03b88: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 8:17 AM
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

I'm going to bring newest m4/iconv.m4 from original (gettext), which apparently fixed file descriptor leaks.

May 13 2019, 8:08 AM · gpgrt, gnupg
gniibe claimed T4504: Asan findings in iconv configure test causing config failure.

Thanks for your report.

May 13 2019, 8:05 AM · gpgrt, gnupg
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

An FYI... Once we cleared the earlier findings GnuPG tested OK under Asan. GnuPG itself had no findings, and it did not cause any dependent libraries to generate findings.

May 13 2019, 7:20 AM · gpgrt, gnupg

May 12 2019

werner committed rG8d0d61aca3d2: sm: Fix a warning in an es_fopencooie function. (authored by werner).
sm: Fix a warning in an es_fopencooie function.
May 12 2019, 8:43 PM
werner triaged T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2" as Normal priority.

Thanks for the tests. I just fixed this one and will do replace some code in master, soon.

May 12 2019, 8:43 PM · gnupg
werner triaged T4502: keys added via gpg-agent's ssh-agent interface are stored in private-keys-v1.d/ with a trailing null byte as Normal priority.

I often put an extra nul byte at the end of binary data so that accidental printing the data (e.g. in gdb) assures that there is a string terminator. But right, it should not go out to a file.

May 12 2019, 8:16 PM · gpgagent, ssh
jukivili added a comment to T4499: Asan finding in libgcrypt.

That type of variadic macro is GCC extension, see https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html

May 12 2019, 6:45 PM · libgcrypt
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

This patch tested OK.

May 12 2019, 11:44 AM · gpgrt, gnupg
JW created T4504: Asan findings in iconv configure test causing config failure in the S1 Public space.
May 12 2019, 10:26 AM · gpgrt, gnupg
kaspro added a comment to T4301: Handling multiple subkeys on two SmartCards.

Hello again - can I ask about the status? Or should I consider this as a no-fix? Anything I can assist with?

May 12 2019, 7:56 AM · Restricted Project, gnupg, scd, Bug Report