Page MenuHome GnuPG
Create Task
Maniphest T7018

Kleopatra: Separate smartcard window with simplified layout
Open, NormalPublic
Actions

Description

  • The Smartcard screen should open in a new, non modal window.
  • The layout for different card type are harmonized.
  • The button clutter is removed in favor of popup and context menus.

more details:

  • Slots of an application are arranged as a table, because there are Smartcard applications with several slots.
  • If the slots themself have no information about their capabilities, the gpg default is used.
  • For each slots keygrip the number of matching keygrips is shown, as well as the primary UID of the most recent certificate.
  • A "refresh" button to re-scan for smartcards.
  • The lower left corner of the screen shows a spinner while scanning for smartcards. this changes to the number of found smartcards.
  • Each slot has an popup menu button with possible actions, and an equivalent context menu.
  • The header are shows information from the smartcard, if available for the application type.
  • In the upper right corner is a popup menu button with general actions for the cards application.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO286652b2995b Allow forcing columns to be hidden
rLIBKLEO1eb85711ad0c a11y: Ensure notification of a11y tools about focus for current item
rLIBKLEO3d0839a868d1 Declare global operator|() functions for flags in global namespace
rLIBKLEOb6507e9262bf Declare global operator|() functions for flags in global namespace
rLIBKLEOde734e97dee4 Add function to get all subkeys for a key grip
rLIBKLEOd7616be8f941 Fix event filtering of QAbstractItemView
rKLEOPATRA Kleopatra
rKLEOPATRA0c6e51bfe253 Use new card key table for PIV cards
rKLEOPATRAaf8eeb4e806e Add possibility to clone a Card
rKLEOPATRA1448dd6db54b Ensure that menu is shown after clicked item is set as current item
rKLEOPATRAb68b34e9a6c4 Store a clone of the Card instead of just some properties of the card
rKLEOPATRAd2b65b7a9c52 Update list of supported smart cards
rKLEOPATRAf9aea00a1437 Rewrite CardKeysView to display all card keys + certificates
rKLEOPATRA82b76815e0c8 Add workaround for missing update when last actions button loses focus
rKLEOPATRAf88b1644e39c Add shared container for actions used in smart card management
rKLEOPATRA4af4ab22e665 Add workaround for missing update when last actions button loses focus
rKLEOPATRA4424eef57b06 Update list of supported smart cards
rKLEOPATRAdf02136eceee Add shared container for actions used in smart card management
rKLEOPATRA1d11d75d09a9 Disable Reload buttons in smart card window when reload is happening
rKLEOPATRA9fa0bbf48289 Emit a general signal on any status change of ReaderStatus
rKLEOPATRA84107e9c2664 Remove upstreamed workaround
rKLEOPATRA6ac7b849ffa8 Move Q_DECLARE_OPERATORS_FOR_FLAGS out of Kleo namespace
rKLEOPATRA75681c5d558b Set up content layout and show common card information in base class
rKLEOPATRAadde85fd94d0 Add a simple common superclass for all smart card widgets
rKLEOPATRAa0971af5cf98 Move getter/setter for certificate data from PIVCard to Card
rKLEOPATRAebd0e522c24a Get the app name from the card
rKLEOPATRAfddb875f1460 Add AppType enum for the different smart card apps
rKLEOPATRA19342e0682e0 Rename SmartCardWidget to SmartCardsWidget
rKLEOPATRAaa905adf515e Show status message when loading smart cards or importing certificates
rKLEOPATRAf80647f0ae6f Add Reload button to smart card view
rKLEOPATRAfe5dee822500 Make reload of smart cards with F5 work in separate window
rKLEOPATRA069f953fca43 Remove obsolete hack to reload smart cards in main window
rKLEOPATRA2d411da666b9 Update smart cards when smart card window is opened
rKLEOPATRAa00d3fa08f47 Use a separate window for smart card management

Related Objects
Search...

Event Timeline

• alexk triaged this task as Normal priority.Feb 27 2024, 1:55 PM
• alexk created this task.
• alexk added a parent task: T6785: Kleopatra: Improvements related to smart cards.
• alexk added a comment.Feb 27 2024, 3:11 PM

For better action names see T6420: Kleopatra: improve layout of and text in smartcard management view.

ikloecker claimed this task.Mar 4 2024, 10:45 AM
• alexk added a project: gpd.Apr 30 2024, 4:45 PM
ikloecker mentioned this in T6787: Kleopatra: Add pinentry counters to smart card management view.Jun 12 2024, 2:22 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 20 2024, 8:39 PM
ikloecker added a commit: rKLEOPATRAa00d3fa08f47: Use a separate window for smart card management.Jun 21 2024, 12:32 PM
ikloecker added a commit: rKLEOPATRA2d411da666b9: Update smart cards when smart card window is opened.
ikloecker added a commit: rKLEOPATRA069f953fca43: Remove obsolete hack to reload smart cards in main window.
ikloecker added a commit: rKLEOPATRAfe5dee822500: Make reload of smart cards with F5 work in separate window.
ikloecker renamed this task from Kleopatra: seperate smartcard window with simplyfied layout to Kleopatra: Separate smartcard window with simplified layout.Jun 21 2024, 2:38 PM
ikloecker added a commit: rKLEOPATRAf80647f0ae6f: Add Reload button to smart card view.Jun 26 2024, 4:37 PM
ikloecker added a commit: rKLEOPATRAaa905adf515e: Show status message when loading smart cards or importing certificates.
ikloecker added a commit: rKLEOPATRA19342e0682e0: Rename SmartCardWidget to SmartCardsWidget.
ikloecker added a commit: rKLEOPATRAfddb875f1460: Add AppType enum for the different smart card apps.Mon, Jul 1, 10:32 PM
ikloecker added a commit: rKLEOPATRAa0971af5cf98: Move getter/setter for certificate data from PIVCard to Card.
ikloecker added a commit: rKLEOPATRAebd0e522c24a: Get the app name from the card.
ikloecker added a commit: rLIBKLEOd7616be8f941: Fix event filtering of QAbstractItemView.Tue, Jul 2, 3:54 PM
ikloecker added a commit: rLIBKLEOde734e97dee4: Add function to get all subkeys for a key grip.
ikloecker added a comment.EditedTue, Jul 2, 4:56 PM

First mock of new UI for PIV

For comparison the old UI for PIV

Remarks:

  • I don't think the key grip column is useful. The key grip is way too long and we hide this information in all other lists by default. The IDs which link different things are the fingerprints. The only useful information the key grip gives here is whether there is a key stored in the slot or not.
  • Usage will be made more verbose. For PIV it overlaps with the names of the slots. We could show a number in the Slot column (although the numbers are pretty arbitrary and don't have any meaning; the key refs would be better, but they are not user friendly) and show the PIV names in the Usage column. On the other hand, "Key Management" doesn't really tell that it's an encryption key.
  • The Created column is empty because PIV keys do not have a creation date (or scdaemon doesn't list it).
  • I omitted the "Number of certificates" column. I propose to show multiple rows if there are multiple certificates for a card key. Otherwise, the user will have no way to get any information about the other certificates with the key grip.
  • The old UI shows the algorithm, but this information is probably not important. I'd still add a column that is hidden by default.
ikloecker added a commit: rKLEOPATRAadde85fd94d0: Add a simple common superclass for all smart card widgets.Wed, Jul 3, 5:07 PM
ikloecker added a commit: rKLEOPATRA75681c5d558b: Set up content layout and show common card information in base class.
ikloecker added a commit: rLIBKLEOb6507e9262bf: Declare global operator|() functions for flags in global namespace.Fri, Jul 12, 9:44 AM
ikloecker added a commit: rLIBKLEO3d0839a868d1: Declare global operator|() functions for flags in global namespace.Fri, Jul 12, 11:45 AM
ikloecker added a commit: rLIBKLEO1eb85711ad0c: a11y: Ensure notification of a11y tools about focus for current item.Fri, Jul 12, 12:25 PM
ikloecker added a commit: rKLEOPATRA6ac7b849ffa8: Move Q_DECLARE_OPERATORS_FOR_FLAGS out of Kleo namespace.Fri, Jul 12, 12:29 PM
ikloecker added a commit: rKLEOPATRA84107e9c2664: Remove upstreamed workaround.
ikloecker added a commit: rLIBKLEO286652b2995b: Allow forcing columns to be hidden.Fri, Jul 12, 2:18 PM
ikloecker added a commit: rKLEOPATRA9fa0bbf48289: Emit a general signal on any status change of ReaderStatus.Fri, Jul 12, 3:16 PM
ikloecker added a commit: rKLEOPATRA1d11d75d09a9: Disable Reload buttons in smart card window when reload is happening.
ikloecker added a commit: rKLEOPATRAdf02136eceee: Add shared container for actions used in smart card management.Fri, Jul 12, 4:29 PM
ikloecker added a commit: rKLEOPATRA4424eef57b06: Update list of supported smart cards.
ikloecker added a commit: rKLEOPATRA4af4ab22e665: Add workaround for missing update when last actions button loses focus.
ikloecker added a comment.Mon, Jul 15, 3:02 PM

For first feedback on the new slot/certificate table.

New UI for PKCS#15 card


For comparison the old UI

Pro:

  • OpenPGP certificates and S/MIME certificates in one table
  • Fingerprint instead of Key ID
  • Show Details button also for S/MIME (previously, only double click opened Details)

Con:

  • No validity information (Valid From, Valid Until)
ikloecker added a comment.Mon, Jul 15, 3:03 PM

Similarly, the table for NetKey cards.

New UI for NetKey card


For comparison the old UI

ikloecker added a commit: rKLEOPATRAf88b1644e39c: Add shared container for actions used in smart card management.Tue, Jul 23, 5:26 PM
ikloecker added a commit: rKLEOPATRA82b76815e0c8: Add workaround for missing update when last actions button loses focus.
ikloecker added a commit: rKLEOPATRAd2b65b7a9c52: Update list of supported smart cards.
ikloecker added a commit: rKLEOPATRAf9aea00a1437: Rewrite CardKeysView to display all card keys + certificates.
ikloecker added a commit: rKLEOPATRAaf8eeb4e806e: Add possibility to clone a Card.
ikloecker added a commit: rKLEOPATRAb68b34e9a6c4: Store a clone of the Card instead of just some properties of the card.
ikloecker added a commit: rKLEOPATRA1448dd6db54b: Ensure that menu is shown after clicked item is set as current item.
ikloecker added a commit: rKLEOPATRA0c6e51bfe253: Use new card key table for PIV cards.
• ebo added a comment.Wed, Jul 24, 4:03 PM

ok, here the comments from our joined feedback session:

  • we like your multiple rows idea for when there are multiple certificates for a key
  • Keygrip: Please remove the whitespace. Making the column hidden by default is ok.
  • add the Algorithm column, shown by default
  • Keep creation date (of the slot) as default column (this date is there for most cards)
  • Usage: use "encrypt", "sign", "certify", "authenticate" (ebos opinion) or "encr", "sign", "cert", "auth" (werner) or "encrypt", "sign", "certify", "auth" (alexk)
  • Slots: do not enumerate slots, always take the slot refs as given by gpg-card. If an additional name exists, it is ok to use the name instead. But there should be a tooltip with the slot ref.