ok, checked with Beta-41

noticed testing T7128: The Token is very long. Is the serial number not unique? That one is much shorter and therefore better to handle visually

tested with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41)

In T6966#189067, @ebo wrote:

This is how the upper part of the "New Group" window looks with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):

It seems that, deviating from the task description, something else was implemented. And it's not even what Andre suggested in the comments but seemingly something inspired by it.
I do not like it.
I think that the color coding of suitable certificates is a no go for a11y. And it clashes with our color marking in VSD. Which in that case is a convenience only, that info is also available in a column. Instead of a tooltip in this case.

This task only dealt with the lower pane. It added the warning icon and the tool tip "This certificate cannot be used for encryption." For the upper pane see T6722.

Checked in Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
Looks ok to me.

This is how the upper part of the "New Group" window looks with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):

The basic task is definitively done and looks good.
It is not clear if the improvement wishes commented later have consensus and they should be addressed in an new ticket, anyway.

Tested with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41)

Phew. Got it. a new script: "gccwrap.sh.in"

With Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41) I see the expected result. The width for the additional columns is as expected too. So I'll mark this task as done.

Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
works as described with pkcs#15 and netkey cards.
(The column width is then the same for those cards)

The latest changes have been backported for VSD 3.3.

The order of states is "expired", "revoked", "disabled", "invalid", "certified", "not certified". Since we show only one state we need to define an order. I guess it would make sense to give "disabled" the highest priority. (I also think that "revoked" should have higher priority than "expired".)

This is how it looked before (VSD 3.2.2):

In T7089#188733, @ebo wrote:

What I see is: If the status of a certificate is "certified" or "not certified" before disabling it, then Kleo shows "disabled" in the User-ID column. If it was "revoked" or "expired", those are not changed. The same is true for the "Status" info in the details.
Is this distinction on purpose? What is the reason?

Well, now it does not occur for me any more, either. Ok, I'm setting this to resolved, this was most likely a situation where Kleopatra could not write to the kleopatrastaterc (in %APPDATA%\kleopatra\) for some reason. This would then be a more general issue, anyhow, for which we need another ticket if we can reproduce this.

with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):

can't reproduce either

I did what you did, didn't even need to restart Kleopatra.

I cannot reproduce this with Version 3.2.2.2405000+git20240712T143635~6033869e1. I open the Details window, go to Subkeys, right-click table header, select Keygrip, close Details window, open it again, go to Subkeys, Keygrip column is still shown. Even after restarting Kleopatra.

With Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41) II can add a keygrip column to the subkey details. But if I close the details window and open it again, the column are no longer selected.

ok, works with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41).

works now, Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41)

fixed in https://invent.kde.org/pim/kleopatra/-/merge_requests/243; we were not calling the visibility logic when initially creating the view.

https://invent.kde.org/pim/kleopatra/-/merge_requests/242

• Don't show the tab if the certificate list was empty before the import
• Show tab when any keys were considered, not only when any keys were imported

ok, new try. As Ingo now clarified that that "nothing was imported" and "nothing was considered" is synonymous for him, then I misunderstood that comment. As far as I understand the "considered" that would mean that a tab would come up for import of unchanged keys, too.

ok, to make it clear how exactly to implement and test this, let me rephrase what my interpretation of your comment is:

Just a small addendum to what Andre wrote: Obviously, no tab should be shown if nothing was imported (i.e. numConsidered is 0).

The final (known) encoding problem with broken umlauts in German error descriptions should be fixed.

The ticket mentioned in the previous comment is T7190: Kleopatra: wrong claim of update in WKD for keys with no mail address.

If one or more keys are refreshed and none of the keys has non-revoked user IDs with email addresses then Kleopatra shouldn't report a result for WKD anymore.

Backported for VSD 3.3.

Turns out

• the singular instead of plural in the German version is a translation thing and should now be fixed (but is not in the testversion beta35)
• there is another issue muddying the waters regarding search in WKD, for which I will create another ticket

I have to correct myself. After restarting Kleopatra, only the following columns are shown, without any changes from my side:

Well, i can live with it. It would be an improvement.
I would prefer if no import tab was created if a key has not been updated and therefore nothing was actually imported. But I see that this would be more complicated to implement and I have no strong opinion on this anyway.

So Tobias fixed the technical reason why there was no import tab shown after the certify questions because I was too lazy (no I had no more time ;-) ) when I implemented this to carry the keylistcontroller around.

Mark for backport to VSD 3.3

On a fresh install Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta35) are now all available columns displayed by default:

Tested with version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta25)

Some logs after entering a wrong reset code (PUK) for an OpenPGP smart card.

404.228467	2024/05/27 15:56:17.987	8056	kleopatra.exe	org.kde.pim.libkleo: sendCommand "SCD PASSWD --reset OPENPGP.2" failed: "Falscher R?ckstellcode" (code: 322, source: SCD)
404.230320	2024/05/27 15:56:17.987	8056	kleopatra.exe	org.kde.pim.libkleo: errorAsString gettext_use_utf8(-1) returns 1
404.230596	2024/05/27 15:56:17.987	8056	kleopatra.exe	org.kde.pim.libkleo: errorAsString error: Falscher R?ckstellcode
404.231068	2024/05/27 15:56:17.987	8056	kleopatra.exe	org.kde.pim.libkleo: errorAsString error (percent-encoded): "Falscher%20R%FCckstellcode"
404.231182	2024/05/27 15:56:17.987	8056	kleopatra.exe	org.kde.pim.kleopatra: ChangePinCommand::slotResult(): "Falscher R?ckstellcode" ( 322 )
404.231315	2024/05/27 15:56:17.987	8056	kleopatra.exe	org.kde.pim.libkleo: errorAsString gettext_use_utf8(-1) returns 1
404.231428	2024/05/27 15:56:17.987	8056	kleopatra.exe	org.kde.pim.libkleo: errorAsString error: Falscher R?ckstellcode
404.231850	2024/05/27 15:56:17.987	8056	kleopatra.exe	org.kde.pim.libkleo: errorAsString error (percent-encoded): "Falscher%20R%FCckstellcode"

In Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta25) the button is not shown any more.
As it was already not shown in VSD 3.2.2, closing this for all workboards

I guess we want to backport the above change for VSD 3.3.

Show S/MIME keys as coming from LDAP in certificate lookup: https://invent.kde.org/pim/kleopatra/-/merge_requests/237

As I wrote "That the first result is selected is a side effect of making the certificate list more accessible." and "When the lookup finished, then the certificate list gets focus so that the users can immediately interact with the result."

This also works for VSD 3.3 (because the required changes/patches are in gpg4win).

Done: https://invent.kde.org/pim/kleopatra/-/merge_requests/236

Fixed and backported for VSD 3.3.

I noticed a bug in the group config migration: T7181

The option "default-new-key-adsk" of gpg can now be read with Kleo::getCryptoConfigEntry, so that we can check if an ADSK is actually configured to decide whether it makes sense to offer the "Add ADSK" action.

Backported to 2.4. Options are now listed with gpgconf.

Testing with various versions of kleopatra, I'm getting differing results:

For the white high-contrast mode we use the normal (black) Breeze icons now. I think for Qt 5 that's all we can do with reasonable effort. For Qt 6/KF6 we have to revisit this anyway because a lot has changed (see T6932).

Selection with unpatched Qt:

Backported for VSD 3.3

Yes. please.