I guess it's now ready for testing
Feed Advanced Search
Nov 13 2024
Nov 13 2024
• ikloecker changed the status of T7331: Kleopatra: Improvements for debug dialog from Open to Testing.
• ikloecker added a comment to T7331: Kleopatra: Improvements for debug dialog.
All changes have been backported for VSD 3.3
• werner added a comment to T7393: Kleopatra: Use event counter CARD of gpg-agent .
FWIW, there is some code in gpa which uses the event counter. It was introduced with
rGPA936825b4b994cdf5900fc987abd9be7889989627
• ebo closed T6847: Kleopatra: Show S/MIME certs for PKCS#15 cards in smart card view, a subtask of T6785: Kleopatra: Improvements related to smart cards, as Resolved.
With Gpg4win-Beta-75+
• ebo edited projects for T7091: Kleopatra: Simple copy key to card, added: gpd5x; removed gpd5x (gpd-5.0.0).
• ebo edited projects for T7091: Kleopatra: Simple copy key to card, added: gpd5x (gpd-5.0.0); removed gpd.
• ebo renamed T6116: Draft: Kleopatra: Card personalization workflow from Kleopatra: Card personalization workflow to Draft: Kleopatra: Card personalization workflow.
• ebo edited projects for T6116: Draft: Kleopatra: Card personalization workflow, added: gpd5x; removed Restricted Project.
• ebo closed T7018: Kleopatra: Separate smartcard window with simplified layout, a subtask of T6785: Kleopatra: Improvements related to smart cards, as Resolved.
I agree, this is done, follow up Tasks will get new tickets
• TobiasFella added a comment to T7382: Kleopatra: CertificateLineEdit popup toggled on every keypress.
This seems to be QWizard-specific behavior. One more reason to port away from that
Nov 12 2024
Nov 12 2024
• werner closed T7386: npth:w32: npth_cond_broadcast only wakes up the first waiter, a subtask of T7378: Kleopatra: loading X.509 certificate from Signature card hangs, as Resolved.
• ebo added a comment to T6846: Kleopatra: learn TCOS cards automatically.
• ikloecker changed the status of T7365: Kleopatra: Error on key generation after using the "Retry" button from Open to Testing.
Should be ready for testing
• ikloecker moved T7365: Kleopatra: Error on key generation after using the "Retry" button from Backlog to WiP on the vsd33 board.
Backported for VSD 3.3
• ikloecker added a project to T7365: Kleopatra: Error on key generation after using the "Retry" button: vsd33.
This bugfix shall be backported for VSD 3.3 as discussed with ebo
• ikloecker moved T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones from Backlog to WiP on the vsd33 board.
Latest changes backported for VSD 3.3
• ikloecker moved T7234: Kleopatra: add disable/enable certificate in context menu from Backlog to WiP on the vsd33 board.
Backported for VSD 3.3
• ikloecker moved T6567: Kleopatra: gpg-agent does not restart when trying to access smart card from Backlog to WiP on the vsd33 board.
And backported for VSD 3.3.
• ikloecker changed the status of T6567: Kleopatra: gpg-agent does not restart when trying to access smart card from Open to Testing.
Fixed.
• ebo closed T6970: Kleopatra: Hide non-matching keygroups when using a key filter, a subtask of T6916: Kleopatra group related improvements, as Resolved.
• ebo moved T6970: Kleopatra: Hide non-matching keygroups when using a key filter from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Gpg4win-Beta-75:
Works. The filters are also applied to groups now and match groups even if not all certificates in them conform to the filter rule.
Tested with OpenPGP ans S/MIME filters.
• gniibe added a comment to T7378: Kleopatra: loading X.509 certificate from Signature card hangs.
For the record, I add the info here too (was: just in xmpp).
• TobiasFella added a comment to T7331: Kleopatra: Improvements for debug dialog.
And to make commands run only once when Enter is pressed: https://invent.kde.org/pim/kleopatra/-/merge_requests/320
Nov 11 2024
Nov 11 2024
• TobiasFella added a comment to T7331: Kleopatra: Improvements for debug dialog.
Hmm, calling QProcess::setStandardInputFile(QProcess::nullDevice()) before start() may be even better than calling closeWriteChannel() after start().
• ebo closed T6880: GPGME (++/qt): Add support for --quick-add-adsk, a subtask of T6879: Kleopatra: Add support for adding an ADSK, as Resolved.
• ebo moved T6879: Kleopatra: Add support for adding an ADSK from Restricted Project Column to Restricted Project Column on the Restricted Project board.
On the Cli, gpg does not give an error but an info message informing that the subkey already exists so there is no error message for Kleopatra to act on.
• TobiasFella added a comment to T7331: Kleopatra: Improvements for debug dialog.
Fix for the crash https://invent.kde.org/pim/kleopatra/-/merge_requests/318
• ebo added a comment to T6879: Kleopatra: Add support for adding an ADSK.
It works in Gpg4win-Beta-75 to add the ADSK to more than one Key.
• ikloecker added a comment to T7331: Kleopatra: Improvements for debug dialog.
The QProcesses we start should be configured with closed stdin so that the started process don't hang waiting for input, e.g. by calling closeWriteChannel() immediately after start(). Or by calling start() with QIODeviceBase::ReadOnly, but, sadly, the documentation of QProcess doesn't document what effect that has.
• ebo closed T7343: Kleopatra: Error formatted incorrectly in certificate creation result dialog as Resolved.
Gpg4win-Beta-75, works:
Gpg4win-Beta-75: This is in principle ok. Even adding further commands to
C:\Program Files (x86)\Gpg4win\etc\xdg\kleopatradebugcommandsrc works:
• TobiasFella moved T6869: Kleopatra: Improve verification results messages (esp. for invalid signature and multiple signatures) from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• werner triaged T7379: Kleopatra: Learning certificates of Signature v2.0 card fails if a Yubikey is plugged in as well as Normal priority.
• gniibe triaged T7378: Kleopatra: loading X.509 certificate from Signature card hangs as High priority.
• gniibe added a comment to T7378: Kleopatra: loading X.509 certificate from Signature card hangs.
@ebo @ikloecker Let me explain my thoughts. If you have time, please help me doing some tests in your environment.
Nov 9 2024
Nov 9 2024
• gniibe added a comment to T7378: Kleopatra: loading X.509 certificate from Signature card hangs.
This shell script running gpg-connect-agent should run successfully:
Nov 8 2024
Nov 8 2024
• ebo added a comment to T7332: Kleopatra: Initial keylisting sometimes fails or hangs for some seconds.
For Beta-75 it looks similar judging from my first tries.
Gpg4win-Beta-75:
Looks good, I see no "EXCEPTION_ACCESS_VIOLATION" after quitting any more.
Instead only: "process started at 14:11:03.007 has terminated with exit code 0"
• ebo moved T6567: Kleopatra: gpg-agent does not restart when trying to access smart card from WiP to Backlog on the vsd33 board.
• ebo changed the status of T6567: Kleopatra: gpg-agent does not restart when trying to access smart card from Testing to Open.
Gpg4win-Beta-75: This does not work.
• ebo moved T6354: All VSD and GPD binaries need a proper product name on Windows. from WiP to Backlog on the vsd33 board.
• ebo changed the status of T6354: All VSD and GPD binaries need a proper product name on Windows. from Testing to Open.
Gpg4win-Beta-75:
Checked the property details of some files in "Progams (X86)" and found several without product name, E.g. libgpg-error-0.dll and other dlls located at C:\Program Files (x86)\GnuPG\bin.
Or gpgolconfig.exe at C:\Program Files (x86)\Gpg4win\bin and the examble from above, libKF5JobWidgets.dll, shows no product name either.
Gpg4win-Beta-75: Symbol is there.
• ebo moved T7331: Kleopatra: Improvements for debug dialog from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved T7321: Kleopatra: add warning symbol to all unusable groups from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved T7343: Kleopatra: Error formatted incorrectly in certificate creation result dialog from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved T7372: Kleopatra: Crash when unplugging smartcard while operation is in progress from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved T6072: Kleopatra: Display "gpgconf -X" from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved T7364: Kleopatra: Crash on Quit from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved T6091: Kleopatra: "Cancel" in the password dialog of "Print secret key" has no effect from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved T6354: All VSD and GPD binaries need a proper product name on Windows. from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo removed a project from T7216: Kleopatra: Integrate "disabled" feature from gpg: Restricted Project.
• ebo closed T7217: Kleopatra: Create an appearance filter for the "disabled" status, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, as Resolved.
• ebo updated the task description for T7217: Kleopatra: Create an appearance filter for the "disabled" status.
• ebo moved T7217: Kleopatra: Create an appearance filter for the "disabled" status from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Ok with me. setting this to resolved, then.
• ebo added a comment to T6666: Draft: Kleopatra: revise certificate list filters.
keep in mind https://dev.gnupg.org/T7217#193778 when tackling this task
• ebo changed the status of T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, from Open to Testing.
• ebo changed the status of T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones from Open to Testing.
• ebo moved T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones from Restricted Project Column to Restricted Project Column on the Restricted Project board.
I like it better than the very long tool tip.
• ebo moved T7234: Kleopatra: add disable/enable certificate in context menu from WiP to Backlog on the vsd33 board.
• ebo moved T7234: Kleopatra: add disable/enable certificate in context menu from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• TobiasFella added a comment to T7217: Kleopatra: Create an appearance filter for the "disabled" status.
Testing the removal of the appearance flag from this filter leads to this situation:
• ebo added a comment to T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones.
Hm, probably I would be for the html-tags, then. Is there an example where one could see how narrow tool tips really get with that option?
• ikloecker added a comment to T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones.
We shouldn't have to add explicit line breaks. Explicit line breaks will lead to bad formatting (German: Flattersatz) for people who use huge font sizes (a11y!) and Qt will wrap long tool tips so that they won't become wider than the screen. Alternatively, we wrap the tool tips (in the code that sets the tool tips) into <html> tags. Then (for whatever reason) Qt will make the tool tips much narrower. (Some people think too narrow, but we have to die one death.)
• TobiasFella added a comment to T7234: Kleopatra: add disable/enable certificate in context menu.
• ebo changed the status of T7217: Kleopatra: Create an appearance filter for the "disabled" status from Testing to Open.
• ebo changed the status of T7217: Kleopatra: Create an appearance filter for the "disabled" status, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, from Testing to Open.
• ebo changed the status of T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, from Testing to Open.
• ebo changed the status of T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones from Testing to Open.
setting this to open for the small fix in the tooltip.
I suggest as new text:
"Disabled certificates are not offered when selecting a certificate to sign with or to encrypt for.\nThey are not shown in the certificate list with most filters."
And I think there should be an additional newline somewhere, as I was shown a much too long tool tip. The German text is not that much longer…
• TobiasFella added a comment to T7234: Kleopatra: add disable/enable certificate in context menu.
Removing the appearance filter won't fix own disabled certificates not being bold; the problem here is that the "My certificates" filter doesn't trigger at all anymore for disabled certificates
• TobiasFella added a comment to T7217: Kleopatra: Create an appearance filter for the "disabled" status.
Agree with removing the appearance filter
• ebo moved T7234: Kleopatra: add disable/enable certificate in context menu from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Yeah. so lets ditch that appearance filter. But that's for ticket T7217. So I'm setting this ticket to done for 4win.
Nov 7 2024
Nov 7 2024
• ikloecker added a comment to T7234: Kleopatra: add disable/enable certificate in context menu.
You mean that a disabled certificate with secret key isn't listed with bold font? That's probably because we have an appearance filter for disabled certificates which takes precedence.
• ikloecker added a comment to T7217: Kleopatra: Create an appearance filter for the "disabled" status.
I agree that it doesn't make sense anymore because we never show disabled and not-disabled certificates next to each other.
• ebo added a comment to T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones.
Gpg4win-Beta-70:
Looks ok.
• ebo added a comment to T7217: Kleopatra: Create an appearance filter for the "disabled" status.
Gpg4win-Beta-70:
There is an appearance filter for disabled certificates now.
Though I wonder if it is really necessary / useful, as we now have regular filters, too. I would have thought we only need the regular filters. I think the appearance filter was to be a stopgap as we did not want to touch the filters at the time when this ticket was created.
What do you say?
• ebo closed T7089: Kleopatra: show "disabled" status, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, as Resolved.
Gpg4win-Beta-70:
All 4 items in the task description are realized as described.
• ebo updated the task description for T7089: Kleopatra: show "disabled" status.
• ebo added a comment to T7234: Kleopatra: add disable/enable certificate in context menu.
gpg4win-Beta-70: works.
I disabled a certificate, it was not shown anymore in the "all" view. Change to the "Disabled" filter and enabled it again -> it shows again with the "All" filter.
Disabling a private certificate does not allow it for signing and not for encrypting to it. It is also not offered for these any more.
But verifying files which were signed by it works.
• ebo added a comment to T7332: Kleopatra: Initial keylisting sometimes fails or hangs for some seconds.
I managed to get the same "loading certificate" message several times in a row on this test instance by stopping and starting Kleopatra in a row twice. After removing the Signature Card 2.0 this did not happen again in 5-6 tries, although I collected 2 lingering listing processes again (not both started on the same startup). Even import of a X.509 certificate worked.
• ebo added a comment to T7332: Kleopatra: Initial keylisting sometimes fails or hangs for some seconds.
Next I managed to have one gpg and one gpgsm process each left over from the last execution of Kleopatra.
After starting Kleopatra new anyway, again "loading certificate cache" and an additional pair of gpg and gpgsm listing processes start.
• ebo added a comment to T7332: Kleopatra: Initial keylisting sometimes fails or hangs for some seconds.
Had a occurrence of the never ending "loading certificate cache" issue again.
There was a leftover gpgsm process from the previous tests (although Kleopatra warned when I closed it, that processes still running in the background were there and would be aborted).
• werner added a comment to T7379: Kleopatra: Learning certificates of Signature v2.0 card fails if a Yubikey is plugged in as well.
• gniibe added a comment to T7379: Kleopatra: Learning certificates of Signature v2.0 card fails if a Yubikey is plugged in as well.
SCD SERIALNO serialno can move the first card in the list in scdaemon.