In T7237#189558, @ikloecker wrote:"Holder" doesn't exist for anything but OpenPGP cards and many people may not set it. Hence, I think it makes little sense to show this in a prominent location if it's empty for most users who don't juggle with loads of OpenPGP cards.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 5 2024
Aug 5 2024
• aheinecke added a comment to T7237: Kleopatra: reorder columns for tables in the new tabs in the certificate details.
In T7226#189443, @jukivili wrote:This patch should fix the issue:
0001-mpi-ec-inline-reduce-register-pressure-on-32-bit-ARM.patch4 KBDownload
• ikloecker added a comment to T7237: Kleopatra: reorder columns for tables in the new tabs in the certificate details.
"Holder" doesn't exist for anything but OpenPGP cards and many people may not set it. Hence, I think it makes little sense to show this in a prominent location if it's empty for most users who don't juggle with loads of OpenPGP cards.
Statically link winpthread
• TobiasFella committed rKLEOPATRAc4fd56594231: Add keyfilter combo and custom filter for suitable certs (authored by • TobiasFella).
Add keyfilter combo and custom filter for suitable certs
• TobiasFella committed rKLEOPATRA9a7cbc3c360e: Fix button enabling then deselecting keys (authored by • TobiasFella).
Fix button enabling then deselecting keys
• TobiasFella committed rKLEOPATRAf44acc9c2caf: Bump libkleo dependency (authored by • TobiasFella).
Bump libkleo dependency
• TobiasFella committed rKLEOPATRAa010e426747d: Remove unnecessary destructor (authored by • TobiasFella).
Remove unnecessary destructor
• TobiasFella committed rKLEOPATRAa3025d0fe85a: Use error icon and move icon to usage column (authored by • TobiasFella).
Use error icon and move icon to usage column
• TobiasFella committed rKLEOPATRA42303a0cb603: Show usage as "unusable" for certificates that can't be in groups (authored by • TobiasFella).
Show usage as "unusable" for certificates that can't be in groups
• werner committed rGa8cef7ebc2b8: scd: New getinfo subcommand "manufacturer" (authored by • werner).
scd: New getinfo subcommand "manufacturer"
As I could not reproduce the issue with different builds I realized that I was compiling and linking GpgOL for development using a very different version of winpthread.
When I switch to a consistent build and runtime library the crash no longer happens. I wonder if we can maybe statically link winpthread, too. But I think that is coming from Gpgme++ since GpgOL only uses windows threads.
• aheinecke triaged T7237: Kleopatra: reorder columns for tables in the new tabs in the certificate details as Normal priority.
Name, E-Mail, Status, Valid From, Valid Until, [Protocol], Key ID, [Fingerprint], [Certification Trust], [Origin], [Last Update], [Issuer], [Serial Number], [Tags], [Algorithm], [Keygrip]
A patch to make sure that certificates with ADSKs can be copied to cards: https://invent.kde.org/pim/kleopatra/-/merge_requests/265
• TobiasFella committed rKLEOPATRA816a267eb0a0: Make CertificateToCardCommand work with keys that have ADSKs (authored by • TobiasFella).
Make CertificateToCardCommand work with keys that have ADSKs
to document the answer to my own question: The serial number is unique for the manufacturer, e.g. Yubico. But serial numbers of devices of different manufacturers might have the same serial numbers, although it is unlikely.
I added some comments to the commit. But
• aheinecke added a comment to rO15412b7cc74c: Change the GpgOL encryption icon according to its state.
This works suprisingly well, without explicit invalidations i would not have expected that get icon is called automatically after the button or a subbutton is clicked. But I think that this then would require at least a test on the oldest supported version from us, too. Do we even have an old GpgOL test system?
• ikloecker committed rM9272b0fb6ebc: w32: Use UTF-8 for localized error descriptions for all threads (authored by • ikloecker).
w32: Use UTF-8 for localized error descriptions for all threads
mmontkowski committed rO15412b7cc74c: Change the GpgOL encryption icon according to its state (authored by mmontkowski).
Change the GpgOL encryption icon according to its state
• ikloecker added a comment to T7185: Calling gettext_use_utf8(1) for the main thread should enable UTF-8 for all later created secondary threads.
Okay. Done in gpgme for gpgrt >= 1.51 (T7188).
Now even the error descriptions that are logged by background threads should have readable umlauts (see T7188).
Tested in our build environment and indeed, just this patch does not solve the issue for aarch64.
• TobiasFella changed the status of T7217: Kleopatra: Create an appearance filter for the "disabled" status, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, from Open to Testing.
• TobiasFella changed the status of T7217: Kleopatra: Create an appearance filter for the "disabled" status from Open to Testing.
• TobiasFella moved T7215: Improve UX of "subkey expiry change" window from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• TobiasFella changed the status of T7215: Improve UX of "subkey expiry change" window from Open to Testing.
• TobiasFella committed rKLEOPATRA3d558a241d56: Run groups edit dialog asynchronously (authored by • TobiasFella).
Run groups edit dialog asynchronously
• ikloecker committed rKLEOPATRA0959257207ae: Copy the fingerprint of a card key without whitespace (authored by • ikloecker).
Copy the fingerprint of a card key without whitespace
• ikloecker committed rKLEOPATRA1f387e708b53: Make F5 (for reload) also work if no smart card is shown (authored by • ikloecker).
Make F5 (for reload) also work if no smart card is shown
• ikloecker committed rKLEOPATRAda1772639cb1: Change default order of columns and rename some columns in card key view (authored by • ikloecker).
Change default order of columns and rename some columns in card key view
• ikloecker committed rKLEOPATRA852ebb0d423a: Inform user about unset card key or card key without certificate (authored by • ikloecker).
Inform user about unset card key or card key without certificate
• ikloecker committed rKLEOPATRAce881a48d180: Ensure correct state of card slot actions (authored by • ikloecker).
Ensure correct state of card slot actions
• ikloecker committed rKLEOPATRAaae5483f493a: Show human-readable card key name instead of card slot ID if available (authored by • ikloecker).
Show human-readable card key name instead of card slot ID if available
• ikloecker committed rKLEOPATRAc01c736baba3: Add function returning human-readable name for a smart card key slot (authored by • ikloecker).
Add function returning human-readable name for a smart card key slot
• ikloecker committed rKLEOPATRA70d7edb9f8d1: Store a const reference to the card in the card keys view (authored by • ikloecker).
Store a const reference to the card in the card keys view
• ikloecker committed rKLEOPATRAf108b1c708c5: Show the slot's keyref instead of an index (authored by • ikloecker).
Show the slot's keyref instead of an index
• ikloecker committed rKLEOPATRAe3c27ea49f5f: Add Algorithm column to card keys view (authored by • ikloecker).
Add Algorithm column to card keys view
• ikloecker committed rKLEOPATRA141764b157a9: Remove no longer used OpenPGPKeyCardWidget (authored by • ikloecker).
Remove no longer used OpenPGPKeyCardWidget
• ikloecker committed rKLEOPATRA4fed1a818324: The Actions column shouldn't stretch (authored by • ikloecker).
The Actions column shouldn't stretch
• ikloecker committed rKLEOPATRA60d0d07137c4: Hide Keygrip column by default (authored by • ikloecker).
Hide Keygrip column by default
• ikloecker committed rKLEOPATRAcb18edc930a0: Show Created column also for PKCS#15 cards by default (authored by • ikloecker).
Show Created column also for PKCS#15 cards by default
• ikloecker committed rKLEOPATRA24c8f11ea825: Use verbs instead of nouns for the usage (authored by • ikloecker).
Use verbs instead of nouns for the usage
• ikloecker committed rKLEOPATRA51e5140988f6: Store creation time of card keys as QDateTime (authored by • ikloecker).
Store creation time of card keys as QDateTime
• ikloecker committed rKLEOPATRAa18fd8471b70: Use new card key table for OpenPGP cards (authored by • ikloecker).
Use new card key table for OpenPGP cards
• ikloecker committed rKLEOPATRA9cfa43b76e47: Use card slot action to create CSR for NetKey card keys (authored by • ikloecker).
Use card slot action to create CSR for NetKey card keys
• ikloecker committed rKLEOPATRAd5473499aa57: Use new card key table for PIV cards (authored by • ikloecker).
Use new card key table for PIV cards
• ikloecker committed rKLEOPATRA57fbc792811c: Use same fonts and colors as main certificate list (authored by • ikloecker).
Use same fonts and colors as main certificate list
• ikloecker committed rKLEOPATRAeddc9c873489: Store a clone of the Card instead of just some properties of the card (authored by • ikloecker).
Store a clone of the Card instead of just some properties of the card
• ikloecker committed rKLEOPATRA94c847f7f10c: Ensure that menu is shown after clicked item is set as current item (authored by • ikloecker).
Ensure that menu is shown after clicked item is set as current item
• ikloecker committed rKLEOPATRA1a2e92a0cb9a: Add possibility to clone a Card (authored by • ikloecker).
Add possibility to clone a Card
• ikloecker committed rKLEOPATRA9e795690290d: Rewrite CardKeysView to display all card keys + certificates (authored by • ikloecker).
Rewrite CardKeysView to display all card keys + certificates
• ikloecker committed rKLEOPATRA02130fbf32e0: Update list of supported smart cards (authored by • ikloecker).
Update list of supported smart cards
• ikloecker committed rKLEOPATRAb510756cde9a: Add workaround for missing update when last actions button loses focus (authored by • ikloecker).
Add workaround for missing update when last actions button loses focus
• ikloecker committed rKLEOPATRA1a4518e6c1d8: Add shared container for actions used in smart card management (authored by • ikloecker).
Add shared container for actions used in smart card management
• TobiasFella committed rKLEOPATRA8a7216ef4d6e: Run groups edit dialog asynchronously (authored by • TobiasFella).
Run groups edit dialog asynchronously
• aheinecke reassigned T5982: GpgOL: More fine grained discovery of content-id / embedded parts from • aheinecke to mmontkowski.
Markus this ticket I find important as it has much user visible impact. While VS-NfD secops say you "should" not use H TML mail, most users and basically all non - VS-NfD users use the default of outlook anyway and use HTML.
• ikloecker moved T7239: GpgME: Add job for disabling/enabling a certificate from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a project to T7227: Kleopatra: Ensure columns are wide enough when they are made visible: vsd33.
Mark for backport. In the past all columns were resized to fit their contents when a single column was made visible.
Mark for backport
l10n daemon script <scripty@kde.org> committed rLIBKLEOe39c5b097fa5: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRAd2f46325a02f: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rLIBKLEObb91eb61fccb: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Aug 4 2024
Aug 4 2024
Here's patch:
0001-Add-PAC-BTI-support-for-AArch64-assembly.patch2 KBDownload
This patch should fix the issue:
0001-mpi-ec-inline-reduce-register-pressure-on-32-bit-ARM.patch4 KBDownload
Ok, so aarch64 assembly would need PAC and BTI support. As far as I have understood these, is that PAC instructions are not needed with current assembly as none of those is storing/loading LR register (all aarch64 assembly functions are leaf functions). So only BTI is needed and that is basically same modification as CET on x86.
This already shows with 9d909cb67e70fd792926ac1e2ab305b2cc96bc27 which initially added ec-inline.h. (Reproducing with old versions like this one requires cherry-picking 693ffa145378682229473b0e811a9cea7c4d307a since otherwise NEON support is disabled at configure time due to implicit functions.)
l10n daemon script <scripty@kde.org> committed rMTP9e27b2be15fb: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rLIBKLEO9db9d77ba0d0: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRAab57a399b6f7: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rMTP64a9cc4344f3: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rLIBKLEO7c547da9bfcd: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRAd0f3c1c97874: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rLIBKLEO96632879749f: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Aug 3 2024
Aug 3 2024
l10n daemon script <scripty@kde.org> committed rLIBKLEOea6f7a56b28c: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRA95cad2d1e5e2: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rMTP05ffeb8e9a61: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRAc1c89a3adc57: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rLIBKLEOddb5879b3293: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Aug 2 2024
Aug 2 2024
• werner added a comment to T7185: Calling gettext_use_utf8(1) for the main thread should enable UTF-8 for all later created secondary threads.
Sounds like a good idea.
I am a bit wary about making this configurable, mostly because this means quite a bit more complexity in the code as the view need to handle two different modes.
• ebo moved T7036: gpgme: gpgme_op_receive_keys does not return an error if keyserver lookup is disabled from Backlog to QA for next release on the gpgme board.
• ebo moved T7036: gpgme: gpgme_op_receive_keys does not return an error if keyserver lookup is disabled from QA to vsd-3.3.0 on the vsd33 board.
• ebo closed T7036: gpgme: gpgme_op_receive_keys does not return an error if keyserver lookup is disabled as Resolved.
with gpg4win-Beta-41:
• ikloecker added a comment to T7185: Calling gettext_use_utf8(1) for the main thread should enable UTF-8 for all later created secondary threads.
@werner Would it be okay to call gettext_use_utf8 (3) in gpgme's do_subsystem_inits where we currently call gettext_use_utf8 (1)? See https://dev.gnupg.org/source/gpgme/browse/master/src/version.c$77
• werner added a comment to T7237: Kleopatra: reorder columns for tables in the new tabs in the certificate details.
Please see the quote from Knuth which explains this.
• werner committed rGfa2c15634ca2: keyboxd: New getinfo subcommand "connections". (authored by • werner).
keyboxd: New getinfo subcommand "connections".
• werner committed rGf1e3a23d9e90: scd: New getinfo subcommand "dump_state". (authored by • werner).
scd: New getinfo subcommand "dump_state".
• TobiasFella committed rKLEOPATRA8b59bfb0a037: Run groups edit dialog asynchronously (authored by • TobiasFella).
Run groups edit dialog asynchronously
• ikloecker added a comment to T7237: Kleopatra: reorder columns for tables in the new tabs in the certificate details.
Actually, it seems to be spelled "smart card" in English (e.g. in Merriam Webster and Oxford English Dictionary). Two words. It's just us ignorant Germans who like to glue words together as if there's no tomorrow.
• TobiasFella committed rKLEOPATRA7c82ad7a149f: Run groups edit dialog asynchronously (authored by • TobiasFella).
Run groups edit dialog asynchronously
• werner added a comment to T7237: Kleopatra: reorder columns for tables in the new tabs in the certificate details.
Please name the smartcard tab column Slot and use Smartcard instead of Token. Most users either have a “Smartcard” or a “Yubikey” and they don't known what we mean by “Token”.