Aug 16 2024
Aug 15 2024
Very good suggestion! +1
I believe Werner and Alexander will agree, too, as we talked about that tab the other day and that showing only the last certification would be preferable
I would propose two more changes to make the dialog behave in a way that seems logical to me:
I like KMessageWidget although I think it's not very accessible, i.e. the user isn't notified when it's shown. Hmm, we could probably focus the message widget when it's shown. Then screen readers should read the text.
I'm not sure this is a good idea. We are trading one UI quirk (all columns except the first one can be moved) with another UI quirk (sometimes all columns can be move and sometimes all columns except the first one can be moved). The first behavior is at least consistent across all views.
If this is easy to solve and backport, I would like to have this in the next release, as we did a lot of column related changes in other tables already for that release.
Looking at why this isn't working correctly, my understanding is that we need to do very specific things to make this work on windows at all, see https://doc.qt.io/qt-6/qwindowsmimeconverter.html and https://doc.qt.io/qt-5/qwinmime.html (which i did not realize before yesterday). Since this would require spending probably a few days on this (and writing different code for qt5 and qt6, unfortunately), I'm proposing to remove this from the release and postponing the implementation for Qt6 until after the next release
Aug 14 2024
This is another side effect of: dd3ff8397aaf62e58fa9405ddc5397cb6bcfdc29 and 1f9c757872b033e1be8199c4d488ac84bf8f07bd before that revision the code that changed IPM.Note.GpgOL.MultipartSigned to IPM.Note.SMIME.MultipartSigned was only executed for S/MIME mails. I do now understand that the code in question at the beginning of decryptVerify_o was meant for other Addins, Outlook Web Interface etc. to ensure that the message class on the server was always IPM.Note.SMIME and not some GpgOL specific class so that outlook or other tools like securePIM would still treat the mail as S/MIME.
This is not a distinct issue from T7242 but the same.
I went for the placeholder text because you asked what should be shown on error. And I would rather not follow your suggestion and show an empty widget but keep the placeholder text then.
I like it. BTW, even the unblocking should not be easy to access because users will anyway enter the wrong PUK and then the card is bricked (ready for a factory reset).
NetKey card widget with Card Actions button (because pictures say more than words)
This is way too much text, people. And changing the placeholder widget wasn't part of the original description. Please create a new ticket for this.
Suggestion for the "placeholder" screen:
Only show "Please insert a compatible smartcard." And then below: "Known supported smartcards are listed at https://gnupg.com/kb/smartcards.html".
Did a quick manual test import and encryption/decryption with VS-Desktop-3.2.93.1-Beta with the relevant test-X509 certificate.
Works as expected.
Mh, in the past I would have thought that drag & drop might be worth it for the use case of browsers where you sometimes need to have your key as a text representation. That was originally the Use Case that stood behind the "Text export" in Kleopatra -> Details -> Export. But nowadays I feel that every text box I write into in browsers somehow supports also to drag a file in there for uploading. Or related I sometimes paste image data directly to phabricator and it is attached as a file. And if browsers can handle that, maybe we are even better suited if we would just export it as application/pgp-keys ? But I can't really specify that as I would develop this myself by trying some mime types on windows and see how the relevant software -> Windows Explorer, Outlook, Browser and maybe some other Office software handles that mime type.
inserted as a text block and not as a file attachment
This is now implemented
I tested it doesnt seem to work reliably on windows, it always exports into my home folder regardless of where I drag and drop in explorer or on the desktop window. The drop also seems to require an additional click while it usually works on windows on release and in Outlook it was inserted as a text block and not as a file attachment. Also, but that might be specific to the broken dev installation i have right now it seems to keep handles to the exported files open so I can't delete them or move them right after.