Backported for VSD 3.3

Backported for VSD 3.3

Let's backport this for VSD 3.3 even if https://dev.gnupg.org/T7227#195685 is just a cosmetic issue. The first impression counts.

Apart from checking the gpgme logs to see if validation is enabled for the key listing this can be tested indirectly by verifying that the Status column isn't too narrow after generating a new certificate in an empty keyring in a VSD version (see https://dev.gnupg.org/T7227#195685).

The changes hat to be reverted, a working solution is planned for later

(ignore the last commit, I assigned the wrong task to it)

I'm not sure what we need for the clipboard that's not already in the SignEncryptWidget. I think the SignEncryptFilesDialog mostly adds functionality for the file handling. It might make more sense to try to share code that's implemented for the Notepad and then wrap this in a simple dialog.

In T7362#195689, @alexk wrote:

Yes, automatic scanning of the clipboard is not good. I withdraw the idea.

I think then we could also include this idea: https://dev.gnupg.org/T5006#195230
And thereby show this information for notepad imports, too.

If we're looking at changing this workflow, we could also consider how those dialogs (especially the "Certificate Import Result") dialog relate to the "Imported Certificates" tab - maybe we can find a way of showing both the relevant contents of the tab and the dialog in a unified view and then no longer need the dialog

All changes proposed here have been implemented. I do plan more changes, but will put them in separate tickets

Yes, automatic scanning of the clipboard is not good. I withdraw the idea.

Maybe we could join the two dialogs, i.e. add the additional text and the Certify button to the import result window.

On the other hand might 2 pop up windows after an import be annoying…
Although the second window has a "do not show again" option.
Any suggestions?

Additionally permanently watching the clipboard for changes can cause some password managers to detect an "attack". As it is discoverable which application accesses the clipboard on windows we had the case where a password manager would not work when Kleopatras clipboard watcher was running. T6642

I think we have to use multiple different texts instead of assuming that we can use something general as "Detailed import results from %1" which fits all cases in all languages.

My comment referred exclusively to Tobias's "In the future [...]" comment.

This is what Tobias means:

Isn't the name of the tab showing the imported certificates "Imported Certficates" or something like that? The filter "All" shows all imported certificates. And when you select the filter OpenPGP you see the subset of imported OpenPGP certificates. Therefore, I don't think it makes sense to add a custom filter.

This issue looks still the same from the user perspective as in the task description with Gpg4win 4.4. Therefore tagging it for gpd5x

Works for me in an NSIS installer. The VSD beta thing also works with copied conf files.
(gpg4win-5.0.0-beta27 with some local mods)

This is long done, but only for Qt 6-based releases. Andre's comment T6663#175481 has also been addressed.

This is long done, but only for Qt 6-based releases.

Backported for VSD 3.3 / Gpg4win 4.4.1.

I'll backport this for VSD 3.3 / Gpg4win 4.4.1. Regression risk is minimal.

T6109 is also closely related and I think it would be addressed by this ticket.

This addresses the same problem as T5950. We should either merge the tickets or just close T5950 (which was more of a support ticket and the reporter has fixed their problem) with reference to this ticket.

I tried to reproduce this with Gpg4win 4.4.0, but it worked for all PKCS#15 cards I tried (dark blue R&S, Genua, ipt.fraunhofer). As soon as the certificates were imported from the card (and a "Do you trust this root certificate" dialog was canceled) the buttons became enabled.

We have to take the list of OIDs to ignore into account that can be configured for gpgsm with ignore-cert-with-oid.

Fixed.

I also checked this on Windows 10 with light, dark and high contrast (theme No. 1) colors:

Fixed. After deleting the certificates belonging to the first two card slots the smartcard window shows

Kleopatra does now read the certificates from the card and import them itself instead of relying on gpgsm --learn-card.

Gpg4win-Beta-94: does not work here, but as the workaround still works, we have no regression. So I remove the vsd33 + gpgcom tag