In T7019#190282, @aheinecke wrote:

I would vote anyway for hiding the smartcard tab if it has no information, just so that we are not confusing, I can otherwise imagine support questions like: "It says something about smartcards, do I need such a smart card?" As smartcards for crypto is not something generally known by users, i assume.

Just thinking about this, we have at least one customer configuration that uses KXMLGui to hide all smartcard actions and the view. And one other that disables certify actions everywhere. We need to check that this still works with the new details view.

I think the executables also use the same values for translation.

I would say this could be treated as a duplicate or subtask of T7147: Kleopatra: Add debug information / Log handling KWatchGnuPG is in my opinion not very useful, since as a developer debugging things the command line and "watchgnupg" without the K are more then enough, KWatchGnuPG is basically just a qprocess output viewer of watchgnupg. IMO it would be similar if we would just execute CMD or Konsole with "watchgnupg" and show that window. Logging to a socket has the advantage that the entries are displayed in the order they come in while with files there is an issue of io synchronization and not all components can log in the same file. But you could use same QProcess / watchgnupg to "sync" the log entires and then write them to a file.

works in VS-Desktop-3.2.93.33-Beta

I wouldn't hide the table. We don't hide any tables (e.g. also in smart card view) if they are empty. I would resize ones on very first show (if restoreColumnLayout() returns false). This fixes the initially cut column titles. And then I'd resize to content when the search results are shown, but also only the very first time (i.e. we'd need to remember the first show).

Okay, I see now that this is US-English and Unicode.

Okay. let me do that for the next library releases.

afaik "Valid Until" is actually available for keys coming from WKD

• The status column is already removed in the gpg4win branch but not yet in the test version
• afaik "Valid Until" is actually available for keys coming from WKD
• For the column widths, we could hide the table until the initial search results come in and then resize to content, or just always resize to content when results come in

Very good suggestion! +1
I believe Werner and Alexander will agree, too, as we talked about that tab the other day and that showing only the last certification would be preferable

I would propose two more changes to make the dialog behave in a way that seems logical to me:

I'm not sure this is a good idea. We are trading one UI quirk (all columns except the first one can be moved) with another UI quirk (sometimes all columns can be move and sometimes all columns except the first one can be moved). The first behavior is at least consistent across all views.

https://invent.kde.org/pim/kleopatra/-/merge_requests/273 and https://invent.kde.org/pim/libkleo/-/merge_requests/127

If this is easy to solve and backport, I would like to have this in the next release, as we did a lot of column related changes in other tables already for that release.

Looking at why this isn't working correctly, my understanding is that we need to do very specific things to make this work on windows at all, see https://doc.qt.io/qt-6/qwindowsmimeconverter.html and https://doc.qt.io/qt-5/qwinmime.html (which i did not realize before yesterday). Since this would require spending probably a few days on this (and writing different code for qt5 and qt6, unfortunately), I'm proposing to remove this from the release and postponing the implementation for Qt6 until after the next release

I went for the placeholder text because you asked what should be shown on error. And I would rather not follow your suggestion and show an empty widget but keep the placeholder text then.

I like it. BTW, even the unblocking should not be easy to access because users will anyway enter the wrong PUK and then the card is bricked (ready for a factory reset).

NetKey card widget with Card Actions button (because pictures say more than words)

This is way too much text, people. And changing the placeholder widget wasn't part of the original description. Please create a new ticket for this.

In T7018#190062, @ebo wrote:

Suggestion for the "placeholder" screen:
Only show "Please insert a compatible smartcard." And then below: "Known supported smartcards are listed at https://gnupg.com/kb/smartcards.html".

Suggestion for the "placeholder" screen:
Only show "Please insert a compatible smartcard." And then below: "Known supported smartcards are listed at https://gnupg.com/kb/smartcards.html".

Mh, in the past I would have thought that drag & drop might be worth it for the use case of browsers where you sometimes need to have your key as a text representation. That was originally the Use Case that stood behind the "Text export" in Kleopatra -> Details -> Export. But nowadays I feel that every text box I write into in browsers somehow supports also to drag a file in there for uploading. Or related I sometimes paste image data directly to phabricator and it is attached as a file. And if browsers can handle that, maybe we are even better suited if we would just export it as application/pgp-keys ? But I can't really specify that as I would develop this myself by trying some mime types on windows and see how the relevant software -> Windows Explorer, Outlook, Browser and maybe some other Office software handles that mime type.

inserted as a text block and not as a file attachment

I tested it doesnt seem to work reliably on windows, it always exports into my home folder regardless of where I drag and drop in explorer or on the desktop window. The drop also seems to require an additional click while it usually works on windows on release and in Outlook it was inserted as a text block and not as a file attachment. Also, but that might be specific to the broken dev installation i have right now it seems to keep handles to the exported files open so I can't delete them or move them right after.

https://invent.kde.org/pim/kleopatra/-/merge_requests/272 and https://invent.kde.org/pim/libkleo/-/merge_requests/126

First: we should do something about the placeholder text, too. It is a bit misleading ("But it says Netkey cards work, why doesn't mine?"…)

Open:

• The lower left corner of the screen shows a spinner while scanning for smartcards. this changes to the number of found smartcards.

Screenshot of the "placeholder" screen while loading smart cards:

T7245 which fixes selection on multiple results has been backported for VSD 3.3

Backported additional changes for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

I'd say go it it.

The implemented behavior at the moment is:

Help -> Additional Documentation -> GnuPG Commandline now brings up the GnuPG Manual in the browser for Gpg4win. This solves the issue that this menu entry (Additional Documentation) existed in Gpg4win and Kleopatra on general Linux but was empty. And the API does exist now to add more entries easily if suggested. I just checked on Linux in master and it worked for me.

As there was some discussion in the ticket: what has been implemented? How can it be tested?

Should be merged for VSD 3.3 to fix the finding made when testing T6936: Kleopatra: Auto-select in case of only one keysearch result (see T6936#187185).

While searching for a different issue I found T6512: keyboxd with data pipe in which as I understand it a keyboxd hang is fixed but the fix in that task is not part of the stable branch and only in master. I might be misunderstanding it but just from reading the comments in T6512 this might be related.

Well for 3.3 we will have full support for high contrast with the correct icons on all platforms, additionally we detect and support dark mode on all Windows 10 Versions > 1709 So this can be resolved. (Both for Qt5 and 6). What I have not yet checked if Qt6::systemInfo::colorScheme reports the correct one under windows 11 desert theme, but as you mention that is also part of a different issue where when then also should clean up the kleo systeminfo etc. if this is reliably supplied as information by qt.

In Kleopatra master the first result is no longer selected if there are multiple certificates.

Should be tested with NVDA on Windows to verify that this works as expected and that we don't get duplicate announcements by the screen reader.