You mean that a disabled certificate with secret key isn't listed with bold font? That's probably because we have an appearance filter for disabled certificates which takes precedence.

I agree that it doesn't make sense anymore because we never show disabled and not-disabled certificates next to each other.

Gpg4win-Beta-70:
Looks ok.

Gpg4win-Beta-70:
There is an appearance filter for disabled certificates now.
Though I wonder if it is really necessary / useful, as we now have regular filters, too. I would have thought we only need the regular filters. I think the appearance filter was to be a stopgap as we did not want to touch the filters at the time when this ticket was created.
What do you say?

Gpg4win-Beta-70:
All 4 items in the task description are realized as described.

gpg4win-Beta-70: works.
I disabled a certificate, it was not shown anymore in the "all" view. Change to the "Disabled" filter and enabled it again -> it shows again with the "All" filter.
Disabling a private certificate does not allow it for signing and not for encrypting to it. It is also not offered for these any more.
But verifying files which were signed by it works.

I have updated the translations of the filters defined in the libkleopatrarc*.desktop files.

gpg4win-Beta-70:
The tooltips are all there now.
But some of the tooltip translations are missing and need to be merged/copied still.
So I'm moving this to backlog, so we do not forget this

works, gpg4win-Beta-70.

Support for NKS (Telesec NetKey card and Signature card v2, both based on TCOS) is very old and predates the support for multiple applications. They are also not as well separated as with Yubikey applications. Thus the auto switching between the NKS app and the SigG app.

@ikloecker Thank you sharing the problem. I don't know much aboug NKS card.

@gniibe It seems that a keylisting (with gpg and gpgsm) interferes with a READKEY --card --no-data -- NKS-NKS3.4571 gpg-agent command and makes it hang until scdaemon is killed.

It looks as if a keylisting interfered with a gpg-agent/scdaemon command.

48458.670390	2024/11/06 12:43:04.238	5772	kleopatra.exe	org.kde.pim.kleopatra: ReaderStatusThread[GUI]::ping()

^ update of the smart cards is requested

48458.670695	2024/11/06 12:43:04.238	5772	kleopatra.exe	org.kde.pim.kleopatra: ReaderStatusThread[2nd]: new iteration command= "__update__"  ; nullSlot= true

^ background thread starts update of the smart cards

48459.147743	2024/11/06 12:43:04.728	5772	kleopatra.exe	org.kde.pim.kleopatra: ReaderStatusThread[GUI]::ping()

^ another update of the smart cards is requested (the request is queued)

48464.804883	2024/11/06 12:43:10.393	5772	kleopatra.exe	org.kde.pim.kleopatra: ReaderStatusThread: Card "89490171500022806460" with app "nks" was added
48464.805095	2024/11/06 12:43:10.393	5772	kleopatra.exe	org.kde.pim.kleopatra: ReaderStatusThread: Card "D2760001240100000006154932910000" with app "openpgp" was added
48464.807483	2024/11/06 12:43:10.393	5772	kleopatra.exe	org.kde.pim.kleopatra: ReaderStatusThread: Card "D2760001240100000006154932910000" with app "piv" was added

^ the background thread completed the update of the smart cards and found three card apps

48464.811286	2024/11/06 12:43:10.393	5772	kleopatra.exe	org.kde.pim.kleopatra: ReaderStatusThread[2nd]: new iteration command= "__update__"  ; nullSlot= true

^ background thread starts another update of the smart cards

48464.924701	2024/11/06 12:43:10.492	5772	kleopatra.exe	org.kde.pim.kleopatra: ReaderStatusThread[GUI]::learnCardsCMS()

^ learn cards is requested (and queued) -> Kleopatra shows the progress overlay

48465.796319	2024/11/06 12:43:11.291	5772	kleopatra.exe	org.kde.pim.libkleo: KeyCache::RefreshKeysJob start

^ a keylisting is started (OpenPGP and S/MIME)

48467.549251	2024/11/06 12:43:12.874	5772	kleopatra.exe	org.kde.pim.libkleo: sendStatusLinesCommand "SCD LEARN --force" : got ( status( "READER" ) = "SCM Microsystems Inc. SPRx32 USB Smart Card Reader 0"
[...]
48467.550423	2024/11/06 12:43:12.875	5772	kleopatra.exe	org.kde.pim.libkleo: sendCommand "READKEY --card --no-data -- NKS-NKS3.4531"
48467.895485	2024/11/06 12:43:13.187	5772	kleopatra.exe	org.kde.pim.libkleo: sendStatusLinesCommand "READKEY --card --no-data -- NKS-NKS3.4531" : got ( )
48467.896400	2024/11/06 12:43:13.188	5772	kleopatra.exe	org.kde.pim.libkleo: sendCommand "READKEY --card --no-data -- NKS-NKS3.45B1"
48468.209551	2024/11/06 12:43:13.471	5772	kleopatra.exe	org.kde.pim.libkleo: sendStatusLinesCommand "READKEY --card --no-data -- NKS-NKS3.45B1" : got ( )
48468.209660	2024/11/06 12:43:13.471	5772	kleopatra.exe	org.kde.pim.libkleo: sendCommand "READKEY --card --no-data -- NKS-NKS3.4571"

^ the background thread sends multiple commands to gpg-agent to gather information about the smart cards
^ the last READKEY command seems to hang

48468.598283	2024/11/06 12:43:13.822	5772	kleopatra.exe	org.kde.pim.libkleo: Kleo::KeyCache::RefreshKeysJob(0x63ccba8) RefreshKeysJob::done

^ the keylisting is done

Backported for VSD 3.3

Canceling the password prompt is now handled correctly, i.e. the operation is aborted without further feedback.

ok, looks good, Gpg4win-Beta-70:

Ok, gpg4win-Beta-70. Looks like this now:

This works with gpg4win-beta-70.

This has also been reported at https://bugs.kde.org/show_bug.cgi?id=477798 (although there a crash occurs). Porting the command to gpgme didn't help, but the remaining problems are in gpg and/or gpgme.

Thanks.

Fixed and backported for VSD 3.3

I have reverted the commit mentioned by Carl and another text codec related commit for the Qt 5 builds. This will hopefully fix the broken umlauts in the progress messages.

Fixed and backported for VSD 3.3

Tested with Gpg4win-Beta-70: works for changing expiry date as well as key creation

Looking at the Windows "Problem reports" I saw that it lists many crashes of Kleopatra since 2024-06-19. An older Kleopatra (gpg4win-4.3.2-beta15, built on 2024-04-16) does not crash on exit. The next Kleopatra (gpg4win-4.3.2-beta23, built on 2024-07-05) does crash on exit. The reports point to the libkleo DLL.

Gpg4win-Beta-70: This works now, the issue can not be reproduced any more like described

In Gpg4win-Beta-70 it looks like this (audit log is redirected):

Tested with 4win-beta-64. In the subkey tab of the details of a secret key there is now an option "Add ADSK" in the burgher menu, iff the option default-new-key-adsk is set.

ALright, let's go with that latest version (rKLEOPATRAab32b52a6cf8)

Applied Tobias installation patch to gpg4win master (vsd33)

@TobiasFella prepared the installation in https://dev.gnupg.org/rW9218ebfb7c01478a6fa7b2892fec4d9fd83ba273 . I left some comments on this commit.

Werner backported this to GnuPG 2.2.45.

right. the installer needs to install kleopatradebugcommandsrc next to libkleopatrarc

• Name is now: "Show GnuPG Configuration"
• When I choose that, the window which opens has a title and a close button, the file extension on saving is .txt

ok, regarding better access to the more detailed error dialog see the above mentioned ticket

Tested wit 4win Beta-70:

Kleopatra (master; KF6)

https://invent.kde.org/pim/kleopatra/-/merge_requests/309

The possibility to drag certificates from Kleopatra to somewhere else has been disabled for Windows builds. The change has also been backported for vsd33. In the vsd33 AppImage it should still be possible to export certificates by dragging them from Kleopatra to, for example, Dolphin. Maybe we still want to remove the vsd33 tag.

In T7322#192972, @ebo wrote:

Which is of course technically correct but why can't we have the much more clear "invalid ADSK ... specified"? I think this would help troubleshooting.

gpg4win-beta-64: The smart card tab introduced by T7020: Kleopatra: add "Smart Card" tab to certificate detail view is gone again

It was decided to remove the tab again: T7249: Kleopatra: Remove tab "Smartcard" in the certificate details window, so its gone in 4win-Beta-64

works for 4win-Beta-64, too but removing vsd33, as this is already in vsd32

Backported for vsd33

Thus the rule is that all our Qt applications except for pinentry need to fist initialize gpgme to get the actually used GNUPGEHOME. gpgconf either takes this from the GNUPGHOME envvar or from its default or via its gpgconf.ctl file.
The latter can eventually be used to move the default homedir to %APPDATA%\gnupg-vsd so to allow using different versions of the gnupg engine.

Backported for vsd33

Backported for vsd33 (as discussed with ebo)

If you use a tabbed layout you will always have the problem that some tabs have lots of whitespace and other tabs have little whitespace or even a scrollbar.

Saw it in a screenshot somewhere, can't find it now. I do not have a version with that commit.

In T7329#192861, @ebo wrote:

Regarding the removal of the stretch: Now there seems to be no space at all before the description. Could we have a one-line space before it?

As this ticket is for vsd33, the nice design tweak has to go into another ticket, it will not be backported to kf5.

A bunch of related merge requests:

This is now merged into master

I like this patch, I created a MR based on it (with some additional simplication) https://invent.kde.org/pim/kleopatra/-/merge_requests/299

What about the simplification below. Add more authors and sort-lines as you like. There is no legal necessary to show a full list of copyright holders. Authors are not a legal term in the context of software because software is not considered a piece or art. From the GNU coding standards related to the version/about output:

The line

Please use https://bugs.kde.org to report bugs.

seems to be hard-coded into the Authors tab. I see it in all KDE applications. Maybe it can be customized.

We could simplify the copyright lines to (if we make sure that the current names are listed as authors)

Copyright 2002-2024 The Kleopatra authors
Copyright 2002, 2004, 2007-2009 Klarälvdalens Datakonsult AB
Copyright 2016-2018 Intevation GmbH
Copyright 2010-2024 g10 Code GmbH

alternatively using © instead of "Copyright". (Using both as in KMail is nonsense because © is the official abbreviation of the word "Copyright".)

and why is the link to the bug tracker in the authors tab?
We could also discuss it the KDE Bugtracker is the best place to link to for that…

When we change the About-dialog we should change some other things there, too, not only the author information.