works

done (gpg4win -Beta41)

I notices this again, even though my display language is german and Kleopatra is german the GnuPG system is using english (gpg-error --locale says en_IE). en_IE was set by virtualbox during windows installation. No environment variables are set related to language.

Looks good, gpg4win-Beta41:

Done, checked with Gpg4win-Beta41

Texts are improved, checked with Gpg4win Beta-41

ok, checked with Beta-41

For pinentry I used the QGuiApplication::styleHints()::colorScheme() API in T7230: pinentry-qt: Show passphrase icon nearly invisible in dark mode and high contrast so I think we finally have this covered.

I added the burger icon to Gpg4win-master.
So remaining here is to remove the right-click actions when a certification is selected.

noticed testing T7128: The Token is very long. Is the serial number not unique? That one is much shorter and therefore better to handle visually

tested with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41)

All tables should now show the keygrip without spacing.

In T6966#189067, @ebo wrote:

This is how the upper part of the "New Group" window looks with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):

It seems that, deviating from the task description, something else was implemented. And it's not even what Andre suggested in the comments but seemingly something inspired by it.
I do not like it.
I think that the color coding of suitable certificates is a no go for a11y. And it clashes with our color marking in VSD. Which in that case is a convenience only, that info is also available in a column. Instead of a tooltip in this case.

This task only dealt with the lower pane. It added the warning icon and the tool tip "This certificate cannot be used for encryption." For the upper pane see T6722.

Checked in Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
Looks ok to me.

Yes, we can phase it out in master which is what Nico is talking about and which uses Qt 6/KF6. Nobody is going to remove KIconLoader from KF5.

This is how the upper part of the "New Group" window looks with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):

The basic task is definitively done and looks good.
It is not clear if the improvement wishes commented later have consensus and they should be addressed in an new ticket, anyway.

Tested with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41)

Btw. Here is a nice backtrace, which I think is similar to the crash part of this Task:

I think the crash in the end is the same we have in T6688: Kleopatra GPGME: Reported assert on exit where quitting kleopatra with running jobs tries to cancel all open contexts and then crashes where the assert would be triggered in debug builds. In T6688 we just hid this issue again by not keeping the deviceinfowatcher running.

Phew. Got it. a new script: "gccwrap.sh.in"

That fixed it.

Fixing this is important for getting the next release out.

Is the QIcon API available in QT5 ? If not we can't phase that out.

As shown in the above screenshots the fix was tested by me.

With Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41) I see the expected result. The width for the additional columns is as expected too. So I'll mark this task as done.

Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
works as described with pkcs#15 and netkey cards.
(The column width is then the same for those cards)

With the fixes a build from Gpg4win master (kf5) should now no longer switch the colors or the icons when in dark mode. This should only be done in high contrast mode. I am adding screenshots from the tests here so I also don't get confused between the different versions:

https://invent.kde.org/pim/kleopatra/-/merge_requests/255 fixes some low-hanging bugs to make the configuration behave more as expected

BTW, gpgme does not yet use --quick-set-ownertrust which can also be used to set the disabled flag. We should replace the interactor by the new command. See rG21f7ad563d for the new command.

Unfortunately, sentence like UIs are a nightmare for translators. The only thing that works for all languages is self-contained text fragments.

We could also phrase it more like a sentence, something like

ok, here the comments from our joined feedback session:

For the certificate list it might make sense to have column-specific tool tips, e.g. to give details on "not certified" in the "User IDs" column. For the fingerprint column (just to pick one example) a tool tip makes little sense.

I started working on this already since we needed to fix the current changes regarding dark mode detection. T7214: Kleopatra: Dark mode detection problems on Windows 10 2016
Darkmode detection in Qt6 works for us, but the icon theme switch does not happen.

The latest changes have been backported for VSD 3.3.

https://invent.kde.org/pim/kleopatra/-/merge_requests/176 removed the checkbox for encrypting to others

Comment edited. We still might want to have that discussion about what we should aim for but this ticket is not the correct place for it. Apologies.

Kleopatra of course respects the disabled status because GnuPG does so. But what is the usecase for further extending this?

I fully agree with ingo.

Let's not make the filtering more complex. It's already complex enough with the search field and the filter drop down. If we want more flexible filtering then this should be solved in a general way and not as Sonderlocke for "disabled". "disabled" is really a niche feature and, in my opinion, doesn't deserve a prominent UI element in the main UI.