In T7018#190062, @ebo wrote:Suggestion for the "placeholder" screen:
Only show "Please insert a compatible smartcard." And then below: "Known supported smartcards are listed at https://gnupg.com/kb/smartcards.html".
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 14 2024
Aug 14 2024
• aheinecke added a comment to T6893: Kleopatra: Drag & Drop certificates to somewhere to export them.
Mh, in the past I would have thought that drag & drop might be worth it for the use case of browsers where you sometimes need to have your key as a text representation. That was originally the Use Case that stood behind the "Text export" in Kleopatra -> Details -> Export. But nowadays I feel that every text box I write into in browsers somehow supports also to drag a file in there for uploading. Or related I sometimes paste image data directly to phabricator and it is attached as a file. And if browsers can handle that, maybe we are even better suited if we would just export it as application/pgp-keys ? But I can't really specify that as I would develop this myself by trying some mime types on windows and see how the relevant software -> Windows Explorer, Outlook, Browser and maybe some other Office software handles that mime type.
• aheinecke changed the status of T6893: Kleopatra: Drag & Drop certificates to somewhere to export them from Testing to Open.
I tested it doesnt seem to work reliably on windows, it always exports into my home folder regardless of where I drag and drop in explorer or on the desktop window. The drop also seems to require an additional click while it usually works on windows on release and in Outlook it was inserted as a text block and not as a file attachment. Also, but that might be specific to the broken dev installation i have right now it seems to keep handles to the exported files open so I can't delete them or move them right after.
Aug 13 2024
Aug 13 2024
• aheinecke committed rGd80345244c10: speedo,w32: Install ntbtls as a library (authored by • aheinecke).
speedo,w32: Install ntbtls as a library
• aheinecke committed rKLEOPATRAa0b0827c4235: Fix build for 64 bit Windows (authored by • aheinecke).
Fix build for 64 bit Windows
Help -> Additional Documentation -> GnuPG Commandline now brings up the GnuPG Manual in the browser for Gpg4win. This solves the issue that this menu entry (Additional Documentation) existed in Gpg4win and Kleopatra on general Linux but was empty. And the API does exist now to add more entries easily if suggested. I just checked on Linux in master and it worked for me.
Aug 12 2024
Aug 12 2024
While searching for a different issue I found T6512: keyboxd with data pipe in which as I understand it a keyboxd hang is fixed but the fix in that task is not part of the stable branch and only in master. I might be misunderstanding it but just from reading the comments in T6512 this might be related.
• aheinecke closed T6484: dll: 64-bit different name for libgcrypt, libksba, ntbtls, and gpgme, a subtask of T6508: Port GnuPG to 64-bit Windows, as Resolved.
• aheinecke closed T6484: dll: 64-bit different name for libgcrypt, libksba, ntbtls, and gpgme as Resolved.
This issue can be resolved in my opinion, as I have tested the 64 bit installer and tested a 64 bit pg4win. The current status of this is that we don't want to have different library names depending on the architecture since it is installed in the same way as linux in different directories. So there is nothing left to do here.
• aheinecke added a comment to T6885: Forwarding mail with attachments embeded into the *.eml file will trigger GpgOL reporting an index out of range.
My suspiction with this is that here the exchange server / outlook parses the mail attachment into MAPI and somehow handles mails differently then other attachments. This automatic conversion regarding attached mails is why we always ask users in Support to send us a problematic mail as a file in a zip archive. Otherwise Exchange will convert an attached Outlook MAPI mail to MIME and on the receiving side we can no longer see the original strucutre. Similar things are probably happening on the receiving side where the MIME eml "file" is converted into a MAPIOBJECT holding the forwarded mail which then confuses our internal knowledge about the attachments causing this error.
Fix make_msi script generation
• aheinecke committed rW236f95ba82c7: Fix a patch file name in EXTRA_DIST (authored by • aheinecke).
Fix a patch file name in EXTRA_DIST
Aug 9 2024
Aug 9 2024
• aheinecke committed rW1ca8e131fc69: Update build system to handle both 32 and 64 bit (authored by • aheinecke).
Update build system to handle both 32 and 64 bit
• aheinecke committed rWe555b289ae19: Docker: Do rsync generated config files (authored by • aheinecke).
Docker: Do rsync generated config files
• aheinecke committed rW173737bef159: Docker: do not create tmp dir for inplace builds (authored by • aheinecke).
Docker: do not create tmp dir for inplace builds
This works now.
Aug 8 2024
Aug 8 2024
I tested it and updated the community wiki documentation to refer to it.
• aheinecke committed rW639bcc2757bf: Update snapshots and switch gpg4win-tools branch (authored by • aheinecke).
Update snapshots and switch gpg4win-tools branch
• aheinecke committed rWe869360ac167: Allo multiople package arguments for gen-tarball (authored by • aheinecke).
Allo multiople package arguments for gen-tarball
Syntax improvements for README
• aheinecke committed rG9e2633937c0c: speedo,w32: Update libassuan dll name in wxs (authored by • aheinecke).
speedo,w32: Update libassuan dll name in wxs
• aheinecke committed rGfd90013a1268: speedo,w32: Fix check for gpg-authcode-sign.sh (authored by • aheinecke).
speedo,w32: Fix check for gpg-authcode-sign.sh
• aheinecke added a comment to T4127: GpgOL: Setting category or flagging crypto mails is not possible.
I am observing strange beavior on WIndows 10 22h2 and OL 16.0.17830.200056 even if no mail is displayed in the reading pane and the selection returns no selected mails, Outlook loads mails which are e.g. right clicked. I think a way which could prevent some problems and allow it again to change flags and categories for unselected mails would be for us to check in the Read event if the mail has some inspector and abort in that case. This could also increase compatibility with other addins. I will do some experiments with it.
• aheinecke closed T6076: Kleopatra: Many icons are hard to see if the dark high-contrast mode is activated, a subtask of T5824: Kleopatra: Full accessibility support, as Resolved.
• aheinecke closed T6076: Kleopatra: Many icons are hard to see if the dark high-contrast mode is activated as Resolved.
Well for 3.3 we will have full support for high contrast with the correct icons on all platforms, additionally we detect and support dark mode on all Windows 10 Versions > 1709 So this can be resolved. (Both for Qt5 and 6). What I have not yet checked if Qt6::systemInfo::colorScheme reports the correct one under windows 11 desert theme, but as you mention that is also part of a different issue where when then also should clean up the kleo systeminfo etc. if this is reliably supplied as information by qt.
Aug 7 2024
Aug 7 2024
Rewrite / Update README
Well, my hope for this was some kind of Format where we keep the keys + the signature together with encrypted files. Because I think it is an extremely common usecase to decrypt a file, modify it and then to reencrypt it to the recipients that it was encrypted to before and I think it would be a good usability improvement if after decryption, when a file is then encrypted again Kleopatra would have the recipient dialog prefilled with the original recipients. T6564: Kleopatra: Re-encrypt an encrypted folder to the original recpients And for Gpgpass this could be used in exactly the same manner just with a diffrent UI and focused on folders with multiple files.
Aug 6 2024
Aug 6 2024
• aheinecke committed rGTO678d5fb6ab52: Allow build against both Qt5 and Qt6 (authored by • aheinecke).
Allow build against both Qt5 and Qt6
• aheinecke committed rGTOd2c1e87369c8: Merge remote-tracking branch 'origin/tobias/qt6' (authored by • aheinecke).
Merge remote-tracking branch 'origin/tobias/qt6'
• aheinecke added a comment to T7242: GpgOL: Shown attachments duplicate on selection of signed emails.
I understand the problem now. The difference between my test yesterday and today was that I had disabled S/MIME support in my GpgOL. Since T7243: GpgOL: multipart/signed OpenPGP SMTP transfered mails are displayed as S/MIME is an issue that makes GpgOL think that it is looking at an S/MIME mail but S/MIME is disabled, it tries to write back the mail to the server in a way so that Outlooks internal S/MIME support can parse it on the next run. In the log you see:
• aheinecke triaged T7243: GpgOL: multipart/signed OpenPGP SMTP transfered mails are displayed as S/MIME as Normal priority.
• aheinecke added a comment to T7242: GpgOL: Shown attachments duplicate on selection of signed emails.
Today this was reproducible for me, too. Not sure what the difference is yet to yesterday I could see in my logs that this time the mails were never completely unloaded so that might be a reason. But we cannot rely on that. So reopening mails must work of course even if the mail stays open. (Good to simulate by keeping outlook spy active on the mail when loading and unloading).
• aheinecke added a comment to T6354: All VSD and GPD binaries need a proper product name on Windows..
To clarify what I mean by the missing VarFileInfo block. Currently the GnuPG binaries have versioninfo.rc files but only the version number is displayed for dlls as their pattern did not have the VerFileInfo block: The libassuan-0.dll displayed in this screenshot is from the 2.2.43 package and the assuan-9.dll is self compiled but including the patch below that. I would like to commit such a patch to all libraries that require it if that is okay with you.
Using signed files would have been my suggestion, too. For me I would say that "allowed to sign" depends on the ownertrust of the signature certificate. If the ownertrust of the certificate is Ultimate then you can accept the recipient list. Ultimate ownertrust is given for your own keys or for the ones marked with trusted-key in the GnuPG configuration.
Aug 5 2024
Aug 5 2024
• aheinecke triaged T7242: GpgOL: Shown attachments duplicate on selection of signed emails as Normal priority.
I cannot reproduce the duplication, there are probably errors in your log regarding that close / discard changes failed or something like that in this case as we leave the original message intact and only add the extracted mime parts as attachments and replace the body with the text mimepart. It would duplicate that when it would "reverrify" a mail that already went thorugh all this. But it is meant that while the mail exists in outlooks memory that GpgOL tracks that, too and so does not decrypt the same mail twice. What I can see is that multipart/signed without encryption is somehow parsed as S/MIME initially. This looks like some new behavior in Office 365 or recent versions of Outlook when the message class is changed to an S/MIME Message class. Which we do to get unmodified access to the MAPI structure. From the data objects looking at the mail in outlook spy:
• aheinecke added a comment to T7237: Kleopatra: reorder columns for tables in the new tabs in the certificate details.
In T7237#189558, @ikloecker wrote:"Holder" doesn't exist for anything but OpenPGP cards and many people may not set it. Hence, I think it makes little sense to show this in a prominent location if it's empty for most users who don't juggle with loads of OpenPGP cards.
Statically link winpthread
As I could not reproduce the issue with different builds I realized that I was compiling and linking GpgOL for development using a very different version of winpthread.
When I switch to a consistent build and runtime library the crash no longer happens. I wonder if we can maybe statically link winpthread, too. But I think that is coming from Gpgme++ since GpgOL only uses windows threads.
• aheinecke triaged T7237: Kleopatra: reorder columns for tables in the new tabs in the certificate details as Normal priority.
Name, E-Mail, Status, Valid From, Valid Until, [Protocol], Key ID, [Fingerprint], [Certification Trust], [Origin], [Last Update], [Issuer], [Serial Number], [Tags], [Algorithm], [Keygrip]
I added some comments to the commit. But
• aheinecke added a comment to rO15412b7cc74c: Change the GpgOL encryption icon according to its state.
This works suprisingly well, without explicit invalidations i would not have expected that get icon is called automatically after the button or a subbutton is clicked. But I think that this then would require at least a test on the oldest supported version from us, too. Do we even have an old GpgOL test system?
• aheinecke reassigned T5982: GpgOL: More fine grained discovery of content-id / embedded parts from • aheinecke to mmontkowski.
Markus this ticket I find important as it has much user visible impact. While VS-NfD secops say you "should" not use H TML mail, most users and basically all non - VS-NfD users use the default of outlook anyway and use HTML.
Aug 1 2024
Aug 1 2024
• aheinecke added a comment to T3733: Kleopatra, Libgpg-error: Let the GUI change the language on Windows.
I mean the system configuration of Windows is just strange and messy. I am only noticing this now more because for my latest Test VMs I used VIrtual Box unattended installation, which installs the system according to the Hosts locale and then you can change the language for your user in Windows. And I ended up with this setting here where the preferred languages differ from the Windows UI language. And we are not alone in a confusion, on this system also Paint is in english, and the Microsoft Calculator, but not Powershell or CMD 🙄 But as GetUserPreferredUILanguages should return (and does according to my tests) the display langue chosen in the drop down as Language[0] and the others with lower priority I think the correct behavior here is to be in German.
• aheinecke added a comment to T3733: Kleopatra, Libgpg-error: Let the GUI change the language on Windows.
In T3733#189355, @ikloecker wrote:Don't change the existing KDE behavior for loading the correct Qt translations which is the same as gettext's behavior. It took quite some time to get it right on Windows for KDE.
• aheinecke added a comment to T3733: Kleopatra, Libgpg-error: Let the GUI change the language on Windows.
With debug output I have confirmed that KConfig uses the defaultLocale at this point to read the VS-NfD name. So one issue here is that KConfig needs to use the Language configured for translations when reading out the config from which we take the VS-NfD name.
Jul 31 2024
Jul 31 2024
• aheinecke closed T4484: GpgOL: Improve handling for always sign, when no S/MIME sec key is available as Wontfix.
We have solved this now by showing a configurable error message in that case instead of hard failure with a cryptic error in T6683: GpgOL: Configurable error if sign is selected and prefer_smime
Noticed this again that it was very slow. I guess how fast it is depends on your wine configuration. I worked it around by disabling winepath for me again. But do we want to change anything here or just move this to wontfix?
• aheinecke added a comment to T3733: Kleopatra, Libgpg-error: Let the GUI change the language on Windows.
I notices this again, even though my display language is german and Kleopatra is german the GnuPG system is using english (gpg-error --locale says en_IE). en_IE was set by virtualbox during windows installation. No environment variables are set related to language.
Jul 30 2024
Jul 30 2024
• aheinecke committed rPf4be34f83fd2: qt: Add dark mode icon variants and detection (authored by • aheinecke).
qt: Add dark mode icon variants and detection
For pinentry I used the QGuiApplication::styleHints()::colorScheme() API in T7230: pinentry-qt: Show passphrase icon nearly invisible in dark mode and high contrast so I think we finally have this covered.
• aheinecke closed T7230: pinentry-qt: Show passphrase icon nearly invisible in dark mode and high contrast as Resolved.
Tested on Linux, modern Windows and Windows 10 2016.
• aheinecke added a comment to T7208: Default keyserver search fails (Gpg4win 4.3.1) no "Inquire" "Callback" set for IPC though keyserver is availab.e.
Hi Bernhard,
• aheinecke triaged T7230: pinentry-qt: Show passphrase icon nearly invisible in dark mode and high contrast as Normal priority.
• aheinecke committed rKLEOPATRA6772572c443c: Make colorscheme configuration menu (authored by • aheinecke).
Make colorscheme configuration menu
• aheinecke committed rKLEOPATRA0d513a56584f: Remove environment variable trick for darkmode (authored by • aheinecke).
Remove environment variable trick for darkmode
Add zstd dependency for Qt
WIP Port to Qt6 / KF6
• aheinecke committed rWbe2f575098fd: Qt6: Move more Patches into archive dir (authored by • aheinecke).
Qt6: Move more Patches into archive dir
• aheinecke committed rW27ff8ea56f47: Qt6: Use KF6_HOST_TOOLING instead of KF5 (authored by • aheinecke).
Qt6: Use KF6_HOST_TOOLING instead of KF5
• aheinecke committed rW4ee99961941e: Qt6: Add patch for ECM to allow building without QML (authored by • aheinecke).
Qt6: Add patch for ECM to allow building without QML
• aheinecke committed rW57e03cfbb893: Add KStatusnotifieritem dependency for Kleo (authored by • aheinecke).
Add KStatusnotifieritem dependency for Kleo
Update patches for KF6
• aheinecke committed rWd57112038c82: Bump version to distinguish Qt6 Version (authored by • aheinecke).
Bump version to distinguish Qt6 Version
Update lower dependency regexps
Take KIO as a snapshot for now
• aheinecke committed rW8cb7a9f82882: Update application packages and defines (authored by • aheinecke).
Update application packages and defines
Update packaging for Qt6
Update Qt library names for Qt6
Fix okular patch
Update EXTRA_DIST with ne patches
Readd qtbase mimetype patch
• aheinecke committed rW378d5dd720af: Add KF6IconWidgets.dll from Kiconthmes (authored by • aheinecke).
Add KF6IconWidgets.dll from Kiconthmes
Include zstd in inst sections
Add qtbase share directory patch
Add GPGOL.js
Update qt to 6.7.0
Update pinentry
Fix Qt6 build
Fix stow of qtbase host symlinks
Update GpgOL.js
• aheinecke committed rWbe03108a148d: Update dll name for the Qt-6.7 windows style (authored by • aheinecke).
Update dll name for the Qt-6.7 windows style
Update gpgol.js to latest master
• aheinecke committed rW2d0899ba7c8a: Add missing patches for Frameworks 6.0.0 (authored by • aheinecke).
Add missing patches for Frameworks 6.0.0
• aheinecke committed rWe57b4a523091: Remove KNotifications also from packages (authored by • aheinecke).
Remove KNotifications also from packages
Remove problematic Qt patch
Add Nicolas Fella's release key
• aheinecke committed rW4ad86890378b: Update patches for using native tools and 6.3.0 (authored by • aheinecke).
Update patches for using native tools and 6.3.0
Update Framewroks to 6.3.0
• aheinecke committed rWef5524fabce0: Add kio patch to remove dep to Qt5Compat (authored by • aheinecke).
Add kio patch to remove dep to Qt5Compat
• aheinecke committed rWb59dcfedcbaa: Add ktextaddons patch to remove unused dbus incs (authored by • aheinecke).
Add ktextaddons patch to remove unused dbus incs
• aheinecke committed rW294a3aaa8e15: Add new macros to build native tooling and use it (authored by • aheinecke).
Add new macros to build native tooling and use it
• aheinecke committed rWf0c32aa2e440: Add PATH and LD_LIBRARY_PATH for native tools (authored by • aheinecke).
Add PATH and LD_LIBRARY_PATH for native tools
• aheinecke committed rW44a732baae6c: Update install files for breeze-icons (authored by • aheinecke).
Update install files for breeze-icons
• aheinecke committed rW6ca623c8a7c3: Merge remote-tracking branch 'origin/master' into work/aheinecke/qt6 (authored by • aheinecke).
Merge remote-tracking branch 'origin/master' into work/aheinecke/qt6
• aheinecke committed rW833dd086a565: Merge remote-tracking branch 'origin/master' into work/aheinecke/qt6 (authored by • aheinecke).
Merge remote-tracking branch 'origin/master' into work/aheinecke/qt6
• aheinecke committed rW5a99977a8c06: Do not build zstd programs for windows (authored by • aheinecke).
Do not build zstd programs for windows