Discussion and background for naming things and german translation

For the icon:

looks good to me on gpg4win-5.0.0-beta167@win10

We decided to

@TobiasFella: please ping on screenshot in MR

Vorschlag Text:

This issue does not occur on master, only on 2.2 and 2.4 branches.

There was another customer wish for this, RT #34722

regarding the 403: one has to try the correct page AFAIK. Didn't research which one, look in the update checker code.

In any case, the actual connectivity test needs to be performed by GnuPG. Otherwise we might just test whether the Qt/KDE libraries can reach versions.gnupg.org, but not whether dirmngr can. Werner proposed something like gpg --fetch-key https://gnupg.org/index.html.

Fixed.

This is resolved in the final Beta15.

That error code is actually not an error code but it is the ERROR state from the Kleo SFM. We have seen that yesterday already.

this exact case is fixed in VS-Desktop-3.3.90.12-Beta
Adding further UIDs and making more certifications still works, too.

For reference the related MRs for upstream:
https://invent.kde.org/plasma/breeze/-/merge_requests/540 (pending)

For reference the related MRs for upstream:
https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/170 (merged)
https://invent.kde.org/frameworks/kcolorscheme/-/merge_requests/43 (merged)

Very likely this bug exists since 2017 when support for promotion of local certifications to exportable certifications was added.

Fixed in gpgmepp for gpd5x. I think for VSD 3.3 we'll add a patch to gpg4win.

yeah, I did not have exactly the same setting for the tests in the different versions… so no regression

After further investigation it looks like this bug exists since quite some time.

Well, I could not reproduce this at any time but tested decryption with long file paths to be sure nothing broke and it worked fine.

The state machine in GpgSignKeyEditInteractor expects to see GET_BOOL sign_uid.okay and it should have answered with Y.

The dialog between gpg and Kleopatra looks like this:

[GNUPG:] KEY_CONSIDERED FADC4675146CFAF3D86F137E1D3C5E6E3DB3C71D 0<LF>
[GNUPG:] GET_LINE keyedit.prompt<LF>
sign
<LF>
[GNUPG:] GOT_IT<LF>
[GNUPG:] GET_BOOL keyedit.sign_all.okay<LF>
N
<LF>
[GNUPG:] GOT_IT<LF>
[GNUPG:] GET_LINE keyedit.prompt<LF>
uid D2C00A207DC184562E41517CBC5EF7175E8535E8
<LF>
[GNUPG:] GOT_IT<LF>
[GNUPG:] GET_LINE keyedit.prompt<LF>
uid 648AC172C3EC45F85AA2E68E46D3FEFABD1F5BD7
<LF>
[GNUPG:] GOT_IT<LF>
[GNUPG:] GET_LINE keyedit.prompt<LF>
sign
<LF>
[GNUPG:] GOT_IT<LF>
[GNUPG:] KEY_CONSIDERED FFDFEE2F0C8F278023284D90B0FBC8D8324859B9 0<LF>
[GNUPG:] GET_BOOL sign_uid.local_promote_okay<LF>
Y
<LF>
[GNUPG:] GOT_IT<LF>
[GNUPG:] GET_BOOL sign_uid.okay<LF>

and then nothing else.

There is no well defined pripority for the CRL DPs. The code enumarates the DP and tries one after the other until it founds one. If you use --ignore-http_dp http DPs are skipped and with --ignore-ldap-dp LDAP DPs are ignored.

Fixed. If high-contrast is active then tool tips now use the same colors as buttons (e.g. white text on black for Kontrast No. 1).

With the above patch for breeze the toolbar and the configuration dialog title now also look correct in high-contrast mode.

The wrong/inconsistent coloring of the icons has been fixed.

After T7587: Kleopatra: High contrast mode isn't respected anymore was fixed this is what the buttons look like in Gpg4win 5:

Fixed. There are still some problems with the icons but those will be dealt with in a separate subticket of T6932: Icons, darkmode and stuff.

kleopatrarc, kleopatrastaterc, klanguageoverriderc, libkleopatrarc, and kxmlgui5/kleopatra/kleopatra.rc are now copied from the old location used by Gpg4win 4.4/VSD 3.3 (%APPDATA%/kleopatra) to the new location used by Gpg4win 5 (%GNUPGHOME%/kleopatra) if they do not yet exist at the new location. This is also logged.

It seems that High Contrast mode is completely ignored with Qt 6/KF6 (at least with Breeze and the built-in default style).

Grep'ing through my checked out codebases, nothing of relevance to us uses short key ids anymore.

I have checked the current usage of Key::has* and Key::can* and they all make sense.

We decided to ditch the display of the private key location for OpenPGP keypairs. Only the subkey locations remain.