I was too optimistic. GPGME is required the following change, too:
diff --git a/src/passphrase.c b/src/passphrase.c index 140cd03a..d07afa91 100644 --- a/src/passphrase.c +++ b/src/passphrase.c @@ -114,6 +114,11 @@ _gpgme_passphrase_status_handler (void *priv, gpgme_status_code_t code, case GPGME_STATUS_CANCELED_BY_USER: return gpg_error (GPG_ERR_CANCELED);
I'd propose applying the patch of mine above to gpg, and suggest users to input empty pass phrase to skip (instead of cancelling).
This could be a minimum change (only gpg). Or else, gpgme needs to change to ignore CANCEL status; I think that it's not easy change.
We should also change the "donate" button to Gpg4win then and the text to "voluntary payment".
as T8022 was backported, this one should be backported, too, if possible. I'll add the tag
I guess those things need to be changed in Kleopatra after @gniibe made the changes in scd. I'll add a Kleo tag for discussion, as we should probably make several tickets from this.
Gpg4win-5.0.1 still shows case 1. (just reproduced.)
Should be tested (but unclear, how): ability to read / send (with both organization/personal accounts)
Ok, thanks. Closing the mail in Mailviewer will remove all temporary opened attachment files, so I'll set this to resolved.
Current state: T6793: Cleanup temporary files / dirs with decrypted content
Looks good to me on gpg4win-5.0.2-beta2 @ win11.
Looks almost good to me on gpg4win-5.0.2-beta2 @ win11.
It doesn't look like much was improved on Kleopatra side in gpg4win-5.0.2-beta-2 @ win11.
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
gpg4win-5.0.2-beta-2 @ win11:
Looks good to me on gpg4win-5.0.2-beta2 @ win11.
Additionally, the action is no longer offered for keys with an encryption-capable secret primary key without secret encryption subkey.
And sharing the secret signing subkey isn't offered anymore if this is a card key.
Is this still a requirement?
There's something wrong. I suspect that gpgme is too old. Yeah, gpg4win 5 uses gpgme 2.0.1 and gpgmepp/gpgmeqt 2.0.0. The changes to force deletion was added later.
well, you are showing 4 pinentry-qt windows above. The reference to pinentry meant those windows.
For verification text improvements we have various other tickets, see T8095. I'll add this one as another of those.
@ikloecker said (paraphrased by me):
Curent state in gpg4win-5.0.2-beta-2 @ win11
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
Looks good to me on gpg4win-5.0.2-beta2 @ win11 (no de-vs-compliance filter):
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
@ikloecker said (paraphrased by me):
Looks good to me on gpg4win-5.0.2-beta2 @ win11.
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
The case above shows the case where the public key for the imported secret key was in the keyring beforehand.
We'll assume that this is something which would probably not occur in real life and don't explicitly handle this.
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
Fixed.
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
All tables should now have a context menu which offers at least the Copy action (with "Copy cell contents to clipboard" as tool tip).
Looks good to me on gpg4win-5.0.2-beta2 @ win11.
Regarding the order of items on the page: It is basically the same order, but the frame for the encryption settings improves the overview.
Debugview:
As far as I remember this is the intended behavior.
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
The missing signature was a problem on my end. The customer mail (to ted / exchange server) works fine if the cert is in the keyring. The testmails (via outlook imap) are fine, too. I still need a better test setup for mails to our exchange accounts, but this is enough to rule out a problem in gpgol. I adjust my former message accordingly.
Tested with gpg4win-5.0.2-beta-2 @ win11.
Hmm ich sehe weiterhin die Signatur.
Tested with Gpg4win-5.0.2-beta2
Looks good to me on gpg4win-5.0.2-beta2 @ win11 (although there might unrelated issues, see notes in the end).
Tests of all messages generated by create-test-data.sh:
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
Looks good to me on gpg4win-5.0.2-beta2 @ win11 (tested via config file and registry)
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
This ticket has been superseded by T7971: Kleopatra: Always use gpgme to find the GnuPG binaries. All changes have been reverted.
This is the dialog window which comes up when importing a team key with the group flag:
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
Looks good to me on gpg4win-5.0.2-beta2 @ win11.
I looked at sm/keydb.c:keydb_set_ephemeral function. It says:
tested with Gpg4win-5.0.2-beta2
I don't really know what you are testing, but as far as I understood the (overly verbose [sigh]) comments the only thing that was implemented is that temporary files are removed when our mail viewer is closed properly. Removing temporary files/folders left over on a crash or reboot or any other forceful termination of the mail viewer or kleopatra would be covered by the already mentioned T6842: Kleopatra: Clean up temporary files on windows.
In this comment above T6793: Cleanup temporary files / dirs with decrypted content another issue was created for this: T6842: Kleopatra: Clean up temporary files on windows
I'm not sure what to expect, before this is implemented, so I just documented it here.
I found out, that successful notepad pgp encryption/signature never had an audit log button (it's also like this in gpg4win-4.4.1 and vsd-3.3.4).
So, everything fine here for gpg4win-5.0.2-beta2 @ win11, vsd still needs to be tested.
Suggestion: When Kleopatra starts up, it should just delete its Temp folder.
Looks good to me on gpg4win-5.0.2-beta2 @ win11:
it was zsh