Now also done for libksba.

Note: With rK3e029a4ed0059116febe05924a14009ca622e3c5 autogen.sh was extended with targets to run converage scripts. However, there is no real documentation and it is questionable whether autogen.sh is the right place - after all the coverage stuff needs more support in a project which can't be easily done in a general way in autogen.sh. These chnages to autogen.sh have meanwhile be replaced by standard autogen.sh.

Yes, please.

@werner Shall this be backported to VSD 3.3? The changes look more dramatic than they are. I mostly reordered existing code.

See: MacPorts Ticket 70267 and MacPorts PR #24601

Oh, I did not notice the change as I clicked to the patch from mail notification. Trying now with the updated one:

Just to make sure, did you use the updated version of the patch? I edited the message with fix candidate and changed the attachment.

Running scratch build on s390x: https://koji.fedoraproject.org/koji/taskinfo?taskID=119376728 with the proposed change. The failure is now:

Done.

Done in 1.11.0.

Done in 3.0.0.

Done in 3.0.0.

Done in 3.0.0.

Added in 3.0.0.

While the above patch worked for MacOS 10.8 and above, MacPorts CI shows a second error for older MacOS versions:

Here's fix candidate (edit, new try):

It looks like various flavors of BSD (including macOS just declare environ when needed): environ -- user environment Note: this is a very old MacOS X man page, however the current version is from 2003, and has the same Synopsis.

This diff for 1.11.0 fixes the problem for me:

The following logic from 1.11.0 acinclude.m4 cannot possibly work to detect _ at the beginning of symbol names:

The problems with colors in high contrast mode were addressed with T6073: Kleopatra: Fix issues with high contrast resp. inverted color scheme. I'm not sure what's left to do. Setting to Testing for getting feedback what's missing.

The toolchain is clang / llvm and the apple ld, native build, not cross compiling.

Different pinentries provide different options. The curses pinentry does not have that external password manager thingy. Mixing GUI and tty use seems to be a rare case.

Didn't you had this problem with 1.10.x ? I can't remember that we changed anything at theat code for years. The only recent change was rC656ca459e which should not have changed anything. Maybe the problem is elsewhere.

Frankly, having environ declared in unistd.h is a glibc convenience and other systems likey don't have it. easy to fix, though.