Backported for VSD 3.3

The additional changes have been backported for VSD 3.3

The additional changes have been backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

Needs to be backported for VSD 3.3

I'm pretty sure that this bug fix should be backported for VSD 3.3.

I'm pretty sure that this should be backported for VSD 3.3.

This has already been fixed by Tobias, but the fix needs to be backported (because this also happens in the branch VSD 3.3 is built from).

The latest commit cannot be backported for VSD 3.3 because it depends on changes made for T7153: Kleopatra: Show all search results (from different origins)/T7155: Kleopatra: Show additional columns in search results by default.

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3

To clarify what I mean by the missing VarFileInfo block. Currently the GnuPG binaries have versioninfo.rc files but only the version number is displayed for dlls as their pattern did not have the VerFileInfo block: The libassuan-0.dll displayed in this screenshot is from the 2.2.43 package and the assuan-9.dll is self compiled but including the patch below that. I would like to commit such a patch to all libraries that require it if that is okay with you.

In T7237#189558, @ikloecker wrote:

"Holder" doesn't exist for anything but OpenPGP cards and many people may not set it. Hence, I think it makes little sense to show this in a prominent location if it's empty for most users who don't juggle with loads of OpenPGP cards.

"Holder" doesn't exist for anything but OpenPGP cards and many people may not set it. Hence, I think it makes little sense to show this in a prominent location if it's empty for most users who don't juggle with loads of OpenPGP cards.

Name, E-Mail, Status, Valid From, Valid Until, [Protocol], Key ID, [Fingerprint], [Certification Trust], [Origin], [Last Update], [Issuer], [Serial Number], [Tags], [Algorithm], [Keygrip]

A patch to make sure that certificates with ADSKs can be copied to cards: https://invent.kde.org/pim/kleopatra/-/merge_requests/265

to document the answer to my own question: The serial number is unique for the manufacturer, e.g. Yubico. But serial numbers of devices of different manufacturers might have the same serial numbers, although it is unlikely.

Now even the error descriptions that are logged by background threads should have readable umlauts (see T7188).

Screenshots of current state:

Mark for backport. In the past all columns were resized to fit their contents when a single column was made visible.

Mark for backport

Please see the quote from Knuth which explains this.

Actually, it seems to be spelled "smart card" in English (e.g. in Merriam Webster and Oxford English Dictionary). Two words. It's just us ignorant Germans who like to glue words together as if there's no tomorrow.

Please name the smartcard tab column Slot and use Smartcard instead of Token. Most users either have a “Smartcard” or a “Yubikey” and they don't known what we mean by “Token”.

Sorry, I can't resist to quote Knuth from his homepage:

Yes, the function to load the user-configured language on application start is very well hidden in kxmlgui. :-)

I mean the system configuration of Windows is just strange and messy. I am only noticing this now more because for my latest Test VMs I used VIrtual Box unattended installation, which installs the system according to the Hosts locale and then you can change the language for your user in Windows. And I ended up with this setting here where the preferred languages differ from the Windows UI language. And we are not alone in a confusion, on this system also Paint is in english, and the Microsoft Calculator, but not Powershell or CMD 🙄 But as GetUserPreferredUILanguages should return (and does according to my tests) the display langue chosen in the drop down as Language[0] and the others with lower priority I think the correct behavior here is to be in German.

In T3733#189355, @ikloecker wrote:

Don't change the existing KDE behavior for loading the correct Qt translations which is the same as gettext's behavior. It took quite some time to get it right on Windows for KDE.

In the past I have also seen quite often that the Qt Translations with standard actions like OK and Cancel were translated differently then KDE Strings. So there is also some difference with that on Windows.

KConfig uses the default locale instead of the system locale by default it seems:
https://invent.kde.org/frameworks/kconfig/-/blob/master/src/core/kconfig.cpp?ref_type=heads#L118
This should probably also use a copy of ki18n's getSystemLocale() instead. Or we set Qt's default locale to this value to get KConfig to use it.

Don't change the existing KDE behavior for loading the correct Qt translations which is the same as gettext's behavior. It took quite some time to get it right on Windows for KDE. The important bits for making the language configured by the user work are in
https://invent.kde.org/frameworks/kxmlgui/-/blob/master/src/kswitchlanguagedialog_p.cpp?ref_type=heads#L64
where the user-configured languages are prepended to LANGUAGE and in
https://invent.kde.org/frameworks/ki18n/-/blob/master/src/i18n/main.cpp?ref_type=heads#L65
where we make sure that we load the correct Qt translations also on non-Linux systems (where Qt doesn't respect LANGUAGE).

checked with Gpg4win-4.3.2-beta41:

With debug output I have confirmed that KConfig uses the defaultLocale at this point to read the VS-NfD name. So one issue here is that KConfig needs to use the Language configured for translations when reading out the config from which we take the VS-NfD name.

We decided how it should be implemented.

• Rename to "GnuPG Configuration Dump"
• Change file extension to .txt
• Add Close button
• Set window title

as this is a regression, I would like to have a fix in the upcoming release

looks fine, gpg4win-Beta41

Try it. It does not do what you think ;-)
You will revoke the certification of the User-Id and not remove that one certification. I should have taken a better example for the screenshot:

I'd say having the "Remove Certification" action when a certification is selected does make sense.

Icon is there in GnuPG-VS-Desktop-3.2.93.32-Beta

and an additional patch to remove the groups button from the toolbar if groups are disabled: https://invent.kde.org/pim/kleopatra/-/merge_requests/261

tested with Version VS-Desktop-3.2.93.32-Beta