To avoid confusion the outer folder is now kept if the name of the archived folder doesn't match the name of the archive.

Done.

Just a quick note: For any operation that imports something I would expect an import result (gpgme_import_result_t) listing the keys that were imported. op_keylist in locate mode is a strange duck because it can list and import at the same time.

Cancel (in pinentry-qt) was made default with rP291089ed476d75c71ef1984a7c081d27e357437d. Marc's ChangeLog entry was

• qt4/main.cpp: (qt_cmd_handler) make Cancel the default button for CONFIRM

It's not that simple. The user could have decrypted multiple archives. Showing an additional message box after all decrypted archives have been moved to the final destination somehow doesn't feel right. And what if an archive and a regular file were decrypted? Should the additional message box also show the final destination of the regular file? I think this needs more thought.

Filter 16 is the new filter for valid certificates. The problem could be that the version you tested did not yet have this filter.

Please briefly try to reproduce on Windows with Gpg4win 5.0.2. At lot has changed since this ticket was created so that it might be fixed already.

I cannot reproduce the empty dialog on Linux with the current build. I always see a correct result dialog for the readable file.

We use individual texts now that all follow the pattern "Detailed results of import from ..." for import from file (file name is displayed), clipboard, notepad, smart card, WKD (URL is displayed), server ("keyserver" or "LDAP server").

Note: This isn't included in Gpg4win 5.0(.2).

Note: This isn't included in Gpg4win 5.0(.2).

Note: This isn't included in Gpg4win 5.0(.2).

Note: This isn't included in Gpg4win 5.0(.2).

I stand partially corrected. Apparently, pinentry-efl also sets close_button. For Gpg4win that's irrelevant because we ship pinentry-qt (and pinentry-w32) which doesn't have this IMHO contra-intuitive behavior.

Upstream MR for reading system config files before user config files: https://invent.kde.org/frameworks/kconfig/-/merge_requests/436

I'd also like to point out that changing the error code from GPG_ERR_CANCELED to GPG_ERR_FULLY_CANCELED could cause regressions in applications.

How do you want to decide whether to show two "Cancel" buttons? How would you call those two "Cancel" buttons? For decryption I can imagine that for example "Try Next Key" and "Cancel Decryption" (or even just "Cancel") would make clear what happens.

Q3 is T7650: Kleopatra: Limit width of KMessageBoxes

In T8076#215372, @werner wrote:

If you specify a primary key the primary key shall be deleted. If there is only an offline or token based primary it can't be deleted. This is what the user requested. We can't change this because otherwise subkeys might be unintentionally deleted.

It would be used for key creation just like the legacy options PGPKeyType and RSAKeySizes were used (and still can be used but only for RSA with different key sizes).

I guess the behavior changed with gpg 2.4, i.e. "With gpg 2.4 (or later), ..."

I don't understand how to reproduce this. When a key is deleted then nothing referencing this key should remain in the key ring. I don't see why it should matter whether the deleted key was a card key or not.

I've added *.pub and *.sec (since we have test keys with those suffixes even in gpgme).

The proposed changes are a bit in conflict with https://dev.gnupg.org/T8158 because T8158 proposes to show another dialog when clicking "No". I guess "Cancel" would suppress the Certify dialog. "No for all" would have a different meaning. I guess we'd also need a "No for all" button for the following "Certify Shared Team Key?" question so that one can abort being asked for each imported secret key by clicking "No for all" twice.

I have explicitly chosen this tab order so that tabbing through the informational fields on the left isn't interrupted by the "Card Actions" button on the right. The alternative would be to put the "Card Actions" button in the tab order between the last informational field on the left and the table.

I cannot reproduce this problem anymore with Gpg4win 5.0.1. The bug seems to have been fixed in the meantime by changes made upstream.

Done.

I don't think that anything of this can be changed in Kleopatra or even gpgme. Kleopatra relies on proper error codes by gpg.

It's impossible to know beforehand (i.e. before the user clicked Save) how the folder is going to be called because it might get a suffix to avoid a collision and this cannot be checked before the user clicks Save. I suggest to remove the useless information where the archive was extracted because it's a temporary location. Instead we could add a message box which tells the user the actual location after the data was moved there.

Additionally, the action is no longer offered for keys with an encryption-capable secret primary key without secret encryption subkey.
And sharing the secret signing subkey isn't offered anymore if this is a card key.

There's something wrong. I suspect that gpgme is too old. Yeah, gpg4win 5 uses gpgme 2.0.1 and gpgmepp/gpgmeqt 2.0.0. The changes to force deletion was added later.

In T7502#214891, @ebo wrote:

Q3: Would you make the text in "Certify shared secret key?" wrap?

In T7502#214891, @ebo wrote:

Q2: For 2 and 3 "Certify new certificate? You have imported an new certificate (public key) […]" is not strictly correct, this could be confusing. Maybe we could use the "Certify shared secret key?" instead and change it a bit to make it fit this case too? How about starting with:
"You have imported a shared secret key / a key without primary part." And then leave out the "shared" in the second sentence and in the window title.

In T7502#214891, @ebo wrote:

Q1: Does showing the "Detailed results of importing" make sense for the above cases? One could argue that we could remove it for all single imports where any dialog is shown.

Fixed.

All tables should now have a context menu which offers at least the Copy action (with "Copy cell contents to clipboard" as tool tip).

As far as I remember this is the intended behavior.

This ticket has been superseded by T7971: Kleopatra: Always use gpgme to find the GnuPG binaries. All changes have been reverted.

I don't really know what you are testing, but as far as I understood the (overly verbose [sigh]) comments the only thing that was implemented is that temporary files are removed when our mail viewer is closed properly. Removing temporary files/folders left over on a crash or reboot or any other forceful termination of the mail viewer or kleopatra would be covered by the already mentioned T6842: Kleopatra: Clean up temporary files on windows.

In T7784#214660, @timegrid wrote:

Just to be sure: The "Show Email" button is still never shown on the notepad, right?

In T7784#214657, @timegrid wrote:

Issues found:

• pgp encrypt/sign does not offer an audit log, the first screenshot in the description ("verschlüsselt und signiert") suggests that this was different before

A different order is pretty much impossible to implement in upstream kconfig without big changes/refactoring.

The registry keys "GnuPG Desktop" and "GnuPG VS-Desktop" now work correctly, i.e. existing registry keys should be considered in the next VSD 4 build.