Awesome, thanks for the report 👍
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 12 2024
Jan 11 2024
And another note: In KF6 icon inverting happens automatically in ksvg or so, so that we don't need to ship breeze-dark anymore. And there will be a BreezeIcons library including the icons that can be used instead of the RCC file. This means we just need a quick fix for VSD and not a general solution for upstream.
Already done with rG89c7eccba51554 which will be in the next VSD release.
One more data point: breeze-icons installs a copy of all breeze icons that do not exist in breeze-dark in the breeze-dark icons folder. So, with icon files on disk breeze-dark has all icons that breeze has even without using breeze as fallback icon theme. Looks like an oversight that the breeze-dark RCC generated by breeze-icons doesn't include missing breeze icons.
KIconTheme sets the fallback theme name to breeze, but those icons cannot be found because we only load the icon theme RCC for breeze-dark. I think we need to load both RCC files in dark mode. No, that doesn't work.
Possible reason: There's a kleopatra.svg in breeze-icons/icons, but there's none in breeze-icons/icons-dark.
The problem has been addressed for all OpenPGP crypto operations on files.
Jan 10 2024
Jan 9 2024
Fixed in gpgme and gnupg 2.2/2.4.
I applied a fix to gnupg which also solves the issue.
Taking over
We did this on purpose once - For Windows ppl it is just weird to see forward slashes.
In T6833#181135, @werner wrote:The fix should go into gpgme to spawn dirmngr with a proper home directory (i.e with forward slashes).
Jan 8 2024
I think the double backslash quoting happens because _gpgme_io_spawn quotes the backslashes and calls gpgme-w32spawn and then gpgme-w32spawn quotes the backslashes again and calls gpgconf. I haven't seen anything in gpgme-w32spawn that would unquote the quotes backslashes. But maybe that's supposed to happen in the background. A comment in the code reads "We have to quote some things because under Windows the program parses the commandline and does some unquoting.", but maybe that's no longer true.
Double backslash quoting is the culprit. For WKD requests the GPGMe QT code makes sure that the dirmngr has been started. This is done by running gpgconf --homedir FOO --launch dirmngr. gpgconf returns the homedir with backslashes on Windows to be be nice to ppl who wonder when they notice (legal) forward slashes on Windowns. Now when the spawn function along with its helper is called, it needs to quote the backslashes. But somewhere on the way back one de-quoting is missing and thus gpg sees double backslashes. That is in general not a problem but when checking whether this is the standard home directory, this does not match and gpg puts the socket into a subdirectory. In turn another dirmngr is started for the WKD purpose.
It is still there in VS-Desktop-3.2.1.0 insofar as 2 dirmngrs are started. It was only fixed insofar that it is no longer more than 2.
It does not matter how many gpgsm instances try to start a daemon. The same code is used for starting and this code first takes a lock. When using gpgconf --launch the same code is used too (indirect by calling gpg-connect-agent NOP /bye wityh options for the respective daemon).
Jan 7 2024
For the record. The code used to detect early on if the dark or bright icon theme should be loaded as a resource caused a crash during startup on at least Windows Server 2016 Enterprise. Our new fix avoids such API but I have created T6921: Kleopatra / Qt6: Improve accessibility detection for "Desert" high contrast scheme and fix it upstream to keep track of this since our fix is not fully complete in that it does not properly detect the Bright (Desert) High contrast mode and it should either be merged into KIconThemes or fixed in / with Qt6.
Jan 5 2024
This is actually fixed already for the next version (with commit https://dev.gnupg.org/rKLEOPATRA655abf9a75e5f1cce8bc52b1cda21440970edfd7). The fix will just not be backported to VSD 3.2 to minimize the risk of another regression.
reopened. Because of reverted commits there is again no error message when trying to write to a write protected folder, see T6917.
moved to milestone 3.2.0, as 3.2.1 does not exist as column...
Works in VS-Desktop-3.1.91.9-Beta.
All non-archive jobs have been extended to allow reading the input directly from files and to allow writing the output. directly to files.
Jan 4 2024
In a first commit, I have switched back to the simple check done by QFileInfo::isWritable() (see https://doc.qt.io/qt-5/qfileinfo.html#isWritable).
Another hint: When they checked "write temporary files in the folder of the encrypted file" they got a message window from gpgex "Error returned by the GnuPG user interface: Input/output error".
